mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: Javi Merino <javi.merino@kernel.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Lukasz Luba <llu.ker.dev@gmail.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Ionela Voinescu <ionela.voinescu@arm.com>,
	Punit Agrawal <punit.agrawal@arm.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Amit Daniel Kachhap <amit.kachhap@gmail.com>,
	Zhang Rui <rui.zhang@intel.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	Linux PM <linux-pm@vger.kernel.org>,
	Lukasz Luba <lukasz.luba@arm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] cpu_cooling: Drop static-power related stuff
Date: Wed, 22 Nov 2017 10:59:21 +0000	[thread overview]
Message-ID: <a9f9e968-c93f-4f84-453c-03914263ac04@arm.com> (raw)
In-Reply-To: <20171121181222.GA4075@localhost.localdomain>

(sorry for chiming in quite late)

On 21/11/17 18:12, Eduardo Valentin wrote:
> On Tue, Nov 21, 2017 at 06:00:07PM +0000, Javi Merino wrote:
>> Hi,
>>
>> On Tue, Nov 21, 2017 at 08:57:06AM -0800, Eduardo Valentin wrote:
>>

[...]

>>
>> In a nutshell, mainline does not want platform specific code, but we
>> haven't figured out how to calculate static power without platform
>> specific code.>
> To, that is still fine to have it as a callback, as long as you have at
> least one user! I still do not understand why Juno static power cannot
> go as platform code that register the callback to implement the static
> power model.
> 

1. It was proved not so useful(anyone can prove otherwise ?)
2. I am told static power is negligible compared to dynamic power with
   new fab processes.
3. It's very hard to even test IPA on Juno as it doesn't reach the
   required critical temperature easily. So as Juno platform maintainer
   I want a test case to test regression before we merge anything.

IMO, if the $subject code is expected to be used on Juno, then my answer
is no if one can't test it reliably and also prove that static power
really matters on Juno. So far, I have heard both the above is not
possible. So please delete the code if Juno is the only user in
short and mid term. We can get the code back if we find any users in
longer term.

-- 
Regards,
Sudeep

  reply	other threads:[~2017-11-22 10:59 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-15  9:19 [PATCH 0/4] cpu_cooling: cooling dev registration cleanups Viresh Kumar
2017-11-15  9:19 ` [PATCH 1/4] cpu_cooling: Make of_cpufreq_power_cooling_register() parse DT Viresh Kumar
2017-11-15  9:19 ` [PATCH 2/4] cpu_cooling: Remove unused cpufreq_power_cooling_register() Viresh Kumar
2017-11-15  9:19 ` [PATCH 3/4] cpu_cooling: Keep only one of_cpufreq*cooling_register() helper Viresh Kumar
2017-11-15  9:19 ` [PATCH 4/4] cpu_cooling: Drop static-power related stuff Viresh Kumar
2017-11-15 10:18   ` Daniel Lezcano
2017-11-15 11:25     ` Viresh Kumar
2017-11-15 15:43     ` Eduardo Valentin
2017-11-15 18:17       ` Rafael J. Wysocki
2017-11-15 18:20         ` Eduardo Valentin
2017-11-16 15:02           ` Ionela Voinescu
2017-11-16 15:20             ` Viresh Kumar
2017-11-16 23:31               ` Rafael J. Wysocki
2017-11-16 23:44                 ` Eduardo Valentin
2017-11-17 11:02                   ` Punit Agrawal
2017-11-17 11:06                     ` Viresh Kumar
2017-11-21 11:30                     ` Ionela Voinescu
2017-11-21 13:06                       ` Daniel Lezcano
2017-11-21 15:56                         ` Lukasz Luba
2017-11-21 16:08                           ` Vincent Guittot
2017-11-21 16:57                             ` Eduardo Valentin
2017-11-21 18:00                               ` Javi Merino
2017-11-21 18:05                                 ` Daniel Lezcano
2017-11-21 18:13                                   ` Eduardo Valentin
2017-11-21 23:32                                     ` Lukasz Luba
2017-11-21 18:12                                 ` Eduardo Valentin
2017-11-22 10:59                                   ` Sudeep Holla [this message]
2017-11-22 11:10                                     ` Viresh Kumar
2017-11-22 11:17                                       ` Sudeep Holla
2017-11-22 15:38                                       ` Eduardo Valentin
2017-11-22 15:34                                     ` Eduardo Valentin
2017-11-22 16:04                                       ` Sudeep Holla
2017-11-22  1:25                                 ` Viresh Kumar
2017-11-22 11:08                                   ` Viresh Kumar
2017-11-21 17:03                             ` Lukasz Luba
2017-11-21 17:09                       ` Eduardo Valentin
2017-11-21 17:49                         ` Daniel Lezcano
2017-11-16  2:47         ` Viresh Kumar
2017-11-17  7:55           ` Daniel Lezcano
2017-11-15 11:31   ` Javi Merino
2017-11-15 11:39     ` Daniel Lezcano
2017-11-15 15:09       ` Eduardo Valentin
2017-11-15 18:08 ` [PATCH 0/4] cpu_cooling: cooling dev registration cleanups Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9f9e968-c93f-4f84-453c-03914263ac04@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=amit.kachhap@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=ionela.voinescu@arm.com \
    --cc=javi.merino@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=llu.ker.dev@gmail.com \
    --cc=lukasz.luba@arm.com \
    --cc=mingo@redhat.com \
    --cc=punit.agrawal@arm.com \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=rostedt@goodmis.org \
    --cc=rui.zhang@intel.com \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®