mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: Joanne Koong <joannelkoong@gmail.com>
Cc: miklos@szeredi.hu, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, horst@birthelmer.de,
	joseph.qi@linux.alibaba.com
Subject: Re: [PATCH v2] fuse: fix premature writetrhough request for large folio
Date: Thu, 15 Jan 2026 09:56:18 +0800	[thread overview]
Message-ID: <a9fa2da0-91e7-4671-95a6-a0a44c83a92d@linux.alibaba.com> (raw)
In-Reply-To: <CAJnrk1bjxyUw58WyiwsyBcJ0CcsBJZKNkcm_U+A+2KSmNqvjyQ@mail.gmail.com>



On 1/15/26 2:41 AM, Joanne Koong wrote:
> On Wed, Jan 14, 2026 at 4:45 AM Jingbo Xu <jefflexu@linux.alibaba.com> wrote:
>>
>> When large folio is enabled and the initial folio offset exceeds
>> PAGE_SIZE, e.g. the position resides in the second page of a large
>> folio, after the folio copying the offset (in the page) won't be updated
>> to 0 even though the expected range is successfully copied until the end
>> of the folio.  In this case fuse_fill_write_pages() exits prematurelly
>> before the request has reached the max_write/max_pages limit.
>>
>> Fix this by eliminating page offset entirely and use folio offset
>> instead.
>>
>> Fixes: d60a6015e1a2 ("fuse: support large folios for writethrough writes")
>> Cc: stable@vger.kernel.org
> 
> This should not need the stable tag or any backports. The bug cannot
> trigger until the future patch for turning on large folios lands.

I think 6.18 stable also needs this fix?

-- 
Thanks,
Jingbo


  reply	other threads:[~2026-01-15  1:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-14 12:45 Jingbo Xu
2026-01-14 18:41 ` Joanne Koong
2026-01-15  1:56   ` Jingbo Xu [this message]
2026-01-15  2:11     ` Jingbo Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9fa2da0-91e7-4671-95a6-a0a44c83a92d@linux.alibaba.com \
    --to=jefflexu@linux.alibaba.com \
    --cc=horst@birthelmer.de \
    --cc=joannelkoong@gmail.com \
    --cc=joseph.qi@linux.alibaba.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®