mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Andrew Morton <akpm@linux-foundation.org>,
	<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] lib: bitmap: add missing MODULE_DESCRIPTION() macros
Date: Tue, 23 Jul 2024 11:47:08 -0700	[thread overview]
Message-ID: <a9fbff19-2ace-44d5-99d1-6df759cd45d1@quicinc.com> (raw)
In-Reply-To: <ZlqQwbOVxw9an-qZ@yury-ThinkPad>

On 5/31/2024 8:08 PM, Yury Norov wrote:
> On Fri, May 31, 2024 at 09:03:11AM -0700, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/find_bit_benchmark.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/cpumask_kunit.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_bitmap.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>> This is the subset of "missing MODULE_DESCRIPTION()" which fall under
>> the scope of the BITMAP API entry in the MAINTAINERS file.
>> ---
>>  lib/cpumask_kunit.c      | 1 +
>>  lib/find_bit_benchmark.c | 1 +
>>  lib/test_bitmap.c        | 1 +
>>  3 files changed, 3 insertions(+)
>>
>> diff --git a/lib/cpumask_kunit.c b/lib/cpumask_kunit.c
>> index a105e6369efc..6b62a6bdd50e 100644
>> --- a/lib/cpumask_kunit.c
>> +++ b/lib/cpumask_kunit.c
>> @@ -152,4 +152,5 @@ static struct kunit_suite test_cpumask_suite = {
>>  };
>>  kunit_test_suite(test_cpumask_suite);
>>  
>> +MODULE_DESCRIPTION("KUnit tests for cpumask");
>>  MODULE_LICENSE("GPL");
>> diff --git a/lib/find_bit_benchmark.c b/lib/find_bit_benchmark.c
>> index d3fb09e6eff1..402e160e7186 100644
>> --- a/lib/find_bit_benchmark.c
>> +++ b/lib/find_bit_benchmark.c
>> @@ -194,4 +194,5 @@ static int __init find_bit_test(void)
>>  }
>>  module_init(find_bit_test);
>>  
>> +MODULE_DESCRIPTION("Test for find_*_bit functions");
>>  MODULE_LICENSE("GPL");
>> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
>> index 6dfb8d46a4ff..65a75d58ed9e 100644
>> --- a/lib/test_bitmap.c
>> +++ b/lib/test_bitmap.c
>> @@ -1486,4 +1486,5 @@ static void __init selftest(void)
>>  
>>  KSTM_MODULE_LOADERS(test_bitmap);
>>  MODULE_AUTHOR("david decotigny <david.decotigny@googlers.com>");
>> +MODULE_DESCRIPTION("Test cases for bitmap API");
>>  MODULE_LICENSE("GPL");
>>
>> ---
>> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
>> change-id: 20240531-lib-bitmap-7ce67db2d173
> 
> Applied in bitmap-for-next.

Hi,
I see this landed in linux-next, but is not currently in Linus' tree for 6.11.
Will you be able to have this pulled during the merge window?
I'm trying to eradicate all of these warnings before 6.11 rc-final.

Thanks!
/jeff


      reply	other threads:[~2024-07-23 18:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-31 16:03 Jeff Johnson
2024-06-01  3:08 ` Yury Norov
2024-07-23 18:47   ` Jeff Johnson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9fbff19-2ace-44d5-99d1-6df759cd45d1@quicinc.com \
    --to=quic_jjohnson@quicinc.com \
    --cc=akpm@linux-foundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®