From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6823613C3F2; Sat, 30 Nov 2024 12:44:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=130.133.4.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732970673; cv=none; b=HyQoIX29sUO7DquSIycRoNW9DvMaCOJTKYpKEw9Zq83GifAML6sDw5nOlXcoRyFZZEc9KNw0qZfyfPVpXiuq9VKrsAIyExcYoMdQV4Pn4wpVLqnEkYg3yD9pFFEeuSNRXeOaFPqPziPoG3mxqj1M0LfFQvYcqTdzkzNq0Q+62nw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732970673; c=relaxed/simple; bh=1SI+u4Ruu5NC+CKZ19d2+gIbTPUulj0vTfhBIWrf1yQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=VhgldxqkRvdjti4in6ib45sulbN6HBJWhwy76KnXgx05g4lIXtu9ywgUBuVNG6m307p6cdGpYe7u/rB3u598LmvnmgUYNxRZSFQxwZZc1H2oU8Rr2019zScAuZaE8ecI9nj0XLpJaxeTNWqFO8dv4cVYooX3SKIojEes7t7898o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=physik.fu-berlin.de; spf=pass smtp.mailfrom=zedat.fu-berlin.de; dkim=pass (2048-bit key) header.d=fu-berlin.de header.i=@fu-berlin.de header.b=GGUM9j+X; arc=none smtp.client-ip=130.133.4.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=physik.fu-berlin.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zedat.fu-berlin.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fu-berlin.de header.i=@fu-berlin.de header.b="GGUM9j+X" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fu-berlin.de; s=fub01; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/QWQFR/J1zJYpOazoefg7VcgFFTkEebLmPHwededqA0=; t=1732970670; x=1733575470; b=GGUM9j+XDRlqgDz3O3oRy1hUSAEMErvPyAtDqvTjWQFcUKrma4QZSwP+//dUbKKHls9J9GB7r3O eZ6J8yKywfM9+ohYTYLr/tYD7hRVXZINNkX1B9wTsvwyROkAXfH1gkzJfw/HWew/OuDfXNOKJUSrO OL25mlbJEKEw7Tl/PHOJAuFRpEvy7xOqP1N0ScYvwHjCrS3r3FFoodkvmCjdcYLg9MAvysBWENuCB xthe6RK8gqkaeBHlDTJU7IZ+vL85d9PC95EHmiJUzEWUh5xgvPhRthTQX+d04Jw2i3GX4z+pm080T o3RsRO5M9ofIyVq9t9fh19zg1qudcdRP2jew==; Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.98) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1tHMpn-000000043YC-10ac; Sat, 30 Nov 2024 13:44:27 +0100 Received: from dynamic-078-054-081-111.78.54.pool.telefonica.de ([78.54.81.111] helo=[192.168.178.50]) by inpost2.zedat.fu-berlin.de (Exim 4.98) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1tHMpn-00000001SuH-0ASF; Sat, 30 Nov 2024 13:44:27 +0100 Message-ID: Subject: Re: [PATCH 13/13] sh/irq: use seq_put_decimal_ull_width() for decimal values From: John Paul Adrian Glaubitz To: David Wang <00107082@163.com>, ysato@users.sourceforge.jp, dalias@libc.org Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org Date: Sat, 30 Nov 2024 13:44:26 +0100 In-Reply-To: References: <20241108162634.9945-1-00107082@163.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-ZEDAT-Hint: PO Hi David, On Sat, 2024-11-30 at 13:41 +0100, John Paul Adrian Glaubitz wrote: > On Sat, 2024-11-09 at 00:26 +0800, David Wang wrote: > > Performance improvement for reading /proc/interrupts on arch sh > >=20 > > Signed-off-by: David Wang <00107082@163.com> > > --- > > arch/sh/kernel/irq.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > >=20 > > diff --git a/arch/sh/kernel/irq.c b/arch/sh/kernel/irq.c > > index 4e6835de54cf..9022d8af9d68 100644 > > --- a/arch/sh/kernel/irq.c > > +++ b/arch/sh/kernel/irq.c > > @@ -43,9 +43,9 @@ int arch_show_interrupts(struct seq_file *p, int prec= ) > > { > > int j; > > =20 > > - seq_printf(p, "%*s: ", prec, "NMI"); > > + seq_printf(p, "%*s:", prec, "NMI"); > > for_each_online_cpu(j) > > - seq_printf(p, "%10u ", per_cpu(irq_stat.__nmi_count, j)); > > + seq_put_decimal_ull_width(p, " ", per_cpu(irq_stat.__nmi_count, j), = 10); > > seq_printf(p, " Non-maskable interrupts\n"); > > =20 > > seq_printf(p, "%*s: %10u\n", prec, "ERR", atomic_read(&irq_err_count)= ); >=20 > Sorry for the very late reply! >=20 > I don't quite understand why seq_put_decimal_ull_width() should be faster= than seq_printf(). >=20 > Can you elaborate on this a bit more? I just checked existing merges of this patch for other architectures which = include a more elaborate patch description. If you could do that for SH as well, I = can pick the patch for v6.14. Adrian --=20 .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913