From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 942BD7082D; Mon, 28 Apr 2025 16:46:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745858784; cv=none; b=bzY94I3H4nk6RVYMGYY1JRmHHU/ZWiabr4x+PL/UoWk9MYMs7o3tICFRTgPuT8ejpZaFErYVLm2Ui8K+3duTrAvopinNn2mf+GFETskQPZw45l2GoM1+kx6Kom60z3kV1b0dLijVyqt9+2Kvbks5GtP2sn1hklTCCDvMz6M2Vtw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745858784; c=relaxed/simple; bh=Z8PCmnJ0yV8qERDqeQfISVPvJ3tqJw2Q7aIBdlyPo/k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ae2QHgO7A/bt1204w33xdWN12kgigiEFQJlJnh3M5hxE4LU7C4sNygoYDu4IThr2JEhZ56PJ4AtLGJ1RHj549wAQ7zjtiOD9U/zzmYdahNJr4kWuaN8hMCSXTHpyzZ858GU25uc8kR6r7ESHkfpJj+DOtUNTq/Pe3ycdQt1B52s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Tlk2eBun; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Tlk2eBun" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A90AEC4CEEC; Mon, 28 Apr 2025 16:46:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745858784; bh=Z8PCmnJ0yV8qERDqeQfISVPvJ3tqJw2Q7aIBdlyPo/k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tlk2eBunYES27PROXmHIGQe3zmMP6HvdTE2sKVLCxFcGCmH8DHxdGjHqd3wobjohg VwJfw0ItrR32xKrcgdCW8TRpmdlk+DeJY1swcEr9VbaiBCu3yyJuag7MxpY9rcCj1j 8nTXrf6GECR+mLe+QAKunFydd77qXJZBtfWsqaoubYbzZfTupDTo+1dZCG4DPhnIKw GE9ORFXi++TgAbviRRmsybWuVr08WLZvPsjcAv5o6bRpncDLzkKDP2jiGKorIc8UjF OQmxqQxbREQlcM8XfaIRqR6lFGfo4bo5dy+E+StVFWQQTe6kZ8U9u+SSstYkVmXSTR 4chXnE6KS/Cag== Date: Mon, 28 Apr 2025 10:46:19 -0600 From: Keith Busch To: Leon Romanovsky Cc: Marek Szyprowski , Jens Axboe , Christoph Hellwig , Jake Edge , Jonathan Corbet , Jason Gunthorpe , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Luis Chamberlain , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni , Nitesh Shetty , Leon Romanovsky Subject: Re: [PATCH v10 23/24] nvme-pci: convert to blk_rq_dma_map Message-ID: References: <007e00134d49160d5edab94a72c35b7b91429b09.1745831017.git.leon@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <007e00134d49160d5edab94a72c35b7b91429b09.1745831017.git.leon@kernel.org> On Mon, Apr 28, 2025 at 12:22:29PM +0300, Leon Romanovsky wrote: > + do { > + if (WARN_ON_ONCE(mapped == entries)) { > + iter.status = BLK_STS_IOERR; > + break; > + } > + nvme_pci_sgl_set_data(&sg_list[mapped++], &iter); I think this should say "++mapped" so that the data blocks start at index 1 (continued below...) > + iod->total_len += iter.len; > + } while (blk_rq_dma_map_iter_next(req, dev->dev, &iod->dma_meta_state, > + &iter)); > > -out_unmap_sg: > - dma_unmap_sgtable(dev->dev, &iod->meta_sgt, rq_dma_dir(req), 0); > -out_free_sg: > - mempool_free(iod->meta_sgt.sgl, dev->iod_meta_mempool); > - return BLK_STS_RESOURCE; > + nvme_pci_sgl_set_seg(sg_list, sgl_dma, mapped); because this here is setting sg_list index 0 to be the segment descriptor. And you also need to increment sgl_dma to point to the element after sg_list, otherwise it's pointing right back to itself, creating a looped list. > + if (unlikely(iter.status)) > + nvme_unmap_metadata(dev, req); > + return iter.status; > }