From: Bagas Sanjaya <bagasdotme@gmail.com>
To: "Ruben Wauters" <rubenru09@aol.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amdgpu: fix unexpected indentation in docs
Date: Mon, 28 Apr 2025 07:22:37 +0700 [thread overview]
Message-ID: <aA7KTVwwI3Wvz_JI@archie.me> (raw)
In-Reply-To: <20250428001249.112238-1-rubenru09@aol.com>
[-- Attachment #1: Type: text/plain, Size: 1932 bytes --]
On Mon, Apr 28, 2025 at 01:01:41AM +0100, Ruben Wauters wrote:
> make htmldocs reports unexpected indentation on line 1119 in the kernel
> doc comment. This was due to alignment of numbers (except the minus)
> which caused indentation. This also had unintended effects on the
> compiled documentation, with breaks and indentation after the -1 option.
>
> This patch fixes the error, and changes the format of the options to be
> more in line with others in the file, while still keeping it readable on
> the code side.
>
> Signed-off-by: Ruben Wauters <rubenru09@aol.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index b9a1ef343c79..6ddfd3ace2ba 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1116,10 +1116,10 @@ module_param_named(rebar, amdgpu_rebar, int, 0444);
> /**
> * DOC: user_queue (int)
> * Enable user queues on systems that support user queues.
> - * -1 = auto (ASIC specific default)
> - * 0 = user queues disabled
> - * 1 = user queues enabled and kernel queues enabled (if supported)
> - * 2 = user queues enabled and kernel queues disabled
> + * (-1 = auto (ASIC specific default),
> + * 0 = user queues disabled,
> + * 1 = user queues enabled and kernel queues enabled (if supported),
> + * 2 = user queues enabled and kernel queues disabled)
> */
> MODULE_PARM_DESC(user_queue, "Enable user queues (-1 = auto (default), 0 = disable, 1 = enable, 2 = enable UQs and disable KQs)");
> module_param_named(user_queue, amdgpu_user_queue, int, 0444);
Already addressed by [1]. Thanks!
[1]: https://lore.kernel.org/linux-doc/20250427023625.14327-2-bagasdotme@gmail.com/
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2025-04-28 0:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250428001249.112238-1-rubenru09.ref@aol.com>
2025-04-28 0:01 ` Ruben Wauters
2025-04-28 0:22 ` Bagas Sanjaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aA7KTVwwI3Wvz_JI@archie.me \
--to=bagasdotme@gmail.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rubenru09@aol.com \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®