From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 173A019EED3 for ; Fri, 18 Apr 2025 08:06:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744963623; cv=none; b=boI5SjgCfIs3AImtUmPZAjQVRwE6gWnwdy7fJPqFg1OryNSZ+A7BSZ5/hPljyhLlhJN63ijHRPgH5RdsZAi0gYtIaKKuLqwVPAqE/C4B4GXyX6zqe4fn4n8Qyg1G7WYmD8yVAGMeYjxNgS55hS/9+xkpHMFd/joYX8Ifig7tB2w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744963623; c=relaxed/simple; bh=4SeNgi1wLdy5CHoMa+2nCAoVEtUaMl4h182JOclLDMc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Hcubf07rPYMGWB5FYR2zbIB2dBCVhQoaWsjRePvcZC2XNpWxwVmjk/D/tQXhZcBeFulJG7Opoo2rFIuhnXBISPgsSwLpKB7ht6rweFC0Bb/YSqenEwXCswmIlm/ISKYbVuOJoCNsFyoh6qXRBaGksbuBhBDG7UeER6awVHoQR1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yAAwBdLl; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yAAwBdLl" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43cfe63c592so18719815e9.2 for ; Fri, 18 Apr 2025 01:06:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744963618; x=1745568418; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=8R7Qp36puqcIKgf+lMIiPQAk3WNF5lMseB0RPPm+UOE=; b=yAAwBdLlQpm4RtZYUBRx5AO8726RCP5kRUBLAltRPcYahuwrK1XTDveqrwzDMWByMM 12UY8xPHXnPbAJIQoOIiWCz6MD52aJMVIxqxU9jVb/ihLfIzGuX6CDVjn6YGeHOgNxvM OTt/V0IE/Sikub3PbOVfgEix9FVmHBeQCliVRDhXWvPpgDZInwtcOwwAYOPfqU2TI3bz /mDr3IJ+JrJnGdCU/KhjRiltWJ7uwCQBO6aFAkjrvSqZ+OIKTAJ16QdzkOzL1S67OH1y JrFYZ27a6v0Kw53I0UhFb0kjz3yGQy53BnYXqRtGm9EmEVsTgyQk5rkJrgnqC4+S+zjG YQMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744963618; x=1745568418; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8R7Qp36puqcIKgf+lMIiPQAk3WNF5lMseB0RPPm+UOE=; b=lxZih0su9JW9S1QpZi/ULsR2TOgGQDnbQiSbMqFETwkoGLBZp19vu30/yRgXI6tCAp eXji4RxurlcgVGzABDJCDqm/zIQP4tIz4LRsZbgpnlVQmIundShgPzZODPQ0CT8SKGdg CrBuxArNhthcYpKYRdOlWowGR34w3kBbYKAcJVoF0ECTwLN0Ewz72FHL2Y0iH+la/EUQ xIRhcOb7NG7EP4l+a83WihLBBt+A/7xnB6yqc7ur9rKKMjY3PQQ+fJoFzPVpGpKzVa87 Os+SaZ0M6HQ8Qiny7wdBbdPCxFFDM+bIO9n3118AAv9PsgtdhrHN/nd68DzXinrr7lwq 6LuQ== X-Forwarded-Encrypted: i=1; AJvYcCWTjnJrgDnKHTn9Wi3KzCscEmf2ClA/ugdlkxHGh3AuDtef1nMz4yFfNsgsq0FtQeCJM9oB6BL0nJSMteo=@vger.kernel.org X-Gm-Message-State: AOJu0YxUxAv8m+kkQ+E/XC1VmMTipEvXQGxvld9gjDB8oe2gZVnFwg4d Mn6yOL4+ZmRHyaQvfGv2NV8nn5LUkBLD2dEkTcWvMV0bzVyLzKkX1CBun0SEsQA= X-Gm-Gg: ASbGncv5DMnvhCAB8MjD0Vvh3SBKpOR1onvfJQKEUhUKCIBQvc7ubyLIrGRXMDZVDiK JX3apAmAIxMjFNvKM1ohOMtz5y2bxVRscdicAtcLpLijK64Ll8/p2VGOmC9LGU7aGBj6nw1oxXQ vGabsQmsa3M5J6jyBSbFalxVRMGZzlrx8qnE3FwJReHp6hiGfZjMcZ/eQJaOjvBDaoeWw8sgjG0 weg1ZPaWu7pfyLZVA2XJ7xMa8nA6EIW+UJoX5WUBKkwKmovOMkfcc5P+fnR2+/HiNwUNc4uHfZ3 bHl/bE6PMYVNSUPM55wTrVWZSpCK7KF+iAC81Ij9wDFSmKjffJ9IoYl1WLrt4MLvQtL1NHabsvH twUo= X-Google-Smtp-Source: AGHT+IGroX56fUpTWu8kdLamlS3WqtQ3AvZMCdPeD85f7x29lyEmfTuKBJbY/GKTp63EX5l2l7D2JQ== X-Received: by 2002:a05:6000:458f:b0:399:7f43:b3a4 with SMTP id ffacd0b85a97d-39efba46366mr1072505f8f.24.1744963618329; Fri, 18 Apr 2025 01:06:58 -0700 (PDT) Received: from mai.linaro.org (146725694.box.freepro.com. [130.180.211.218]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4406e0056c0sm7725435e9.0.2025.04.18.01.06.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Apr 2025 01:06:57 -0700 (PDT) Date: Fri, 18 Apr 2025 10:06:55 +0200 From: Daniel Lezcano To: Anand Moon Cc: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Zhang Rui , Lukasz Luba , Alim Akhtar , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , "open list:SAMSUNG THERMAL DRIVER" , "open list:SAMSUNG THERMAL DRIVER" , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , open list , "open list:CLANG/LLVM BUILD SUPPORT:Keyword:b(?i:clang|llvm)b" Subject: Re: [PATCH v5 1/3] drivers/thermal/exynos: Refactor clk_sec initialization inside SOC-specific case Message-ID: References: <20250410063754.5483-1-linux.amoon@gmail.com> <20250410063754.5483-2-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250410063754.5483-2-linux.amoon@gmail.com> On Thu, Apr 10, 2025 at 12:07:48PM +0530, Anand Moon wrote: > Refactor the initialization of the clk_sec clock to be inside the > SOC_ARCH_EXYNOS5420_TRIMINFO case. It ensures that the clk_sec clock > is only initialized for the specified SOC and not for other SOCs, > thereby simplifying the code. The clk_sec clock is used by the TMU > for GPU on the Exynos 542x platform. > > Removed redundant IS_ERR() checks for the clk_sec clock since error > handling is already managed internally by clk_unprepare() functions. > > Signed-off-by: Anand Moon > --- > v5: None > v4: Fix the aligment of code clk for clk_prepare in proper if/else block. > update the commit for clk_sec used. > checked to goto clean up all the clks are proper. > drop IS_ERR() check for clk_sec. > v3: improve the commit message. > --- > drivers/thermal/samsung/exynos_tmu.c | 37 ++++++++++++++-------------- > 1 file changed, 18 insertions(+), 19 deletions(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c > index 47a99b3c5395..3657920de000 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -1037,29 +1037,30 @@ static int exynos_tmu_probe(struct platform_device *pdev) > return ret; > > data->clk = devm_clk_get(dev, "tmu_apbif"); > - if (IS_ERR(data->clk)) > + if (IS_ERR(data->clk)) { > return dev_err_probe(dev, PTR_ERR(data->clk), "Failed to get clock\n"); As this branch returns, the else block can be removed. if (IS_ERR(data->clk)) return dev_err_probe(dev, PTR_ERR(data->clk), "Failed to get clock\n"); ret = clk_prepare(data->clk); if (ret) { ... } May be worth to group both calls with devm_clk_get_enabled() > - > - data->clk_sec = devm_clk_get(dev, "tmu_triminfo_apbif"); > - if (IS_ERR(data->clk_sec)) { > - if (data->soc == SOC_ARCH_EXYNOS5420_TRIMINFO) > - return dev_err_probe(dev, PTR_ERR(data->clk_sec), > - "Failed to get triminfo clock\n"); > } else { > - ret = clk_prepare(data->clk_sec); > + ret = clk_prepare(data->clk); > if (ret) { > dev_err(dev, "Failed to get clock\n"); > return ret; > } > } > > - ret = clk_prepare(data->clk); > - if (ret) { > - dev_err(dev, "Failed to get clock\n"); > - goto err_clk_sec; > - } > - > switch (data->soc) { > + case SOC_ARCH_EXYNOS5420_TRIMINFO: > + data->clk_sec = devm_clk_get(dev, "tmu_triminfo_apbif"); > + if (IS_ERR(data->clk_sec)) { > + ret = dev_err_probe(dev, PTR_ERR(data->clk_sec), > + "Failed to get clk_sec clock\n"); > + goto err_clk; > + } > + ret = clk_prepare(data->clk_sec); Same comment, devm_clk_get_enabled() > + if (ret) { > + dev_err(dev, "Failed to prepare clk_sec clock\n"); > + goto err_clk_sec; > + } > + break; > case SOC_ARCH_EXYNOS5433: > case SOC_ARCH_EXYNOS7: > data->sclk = devm_clk_get(dev, "tmu_sclk"); > @@ -1112,11 +1113,10 @@ static int exynos_tmu_probe(struct platform_device *pdev) > > err_sclk: > clk_disable_unprepare(data->sclk); > +err_clk_sec: > + clk_unprepare(data->clk_sec); > err_clk: > clk_unprepare(data->clk); > -err_clk_sec: > - if (!IS_ERR(data->clk_sec)) > - clk_unprepare(data->clk_sec); With devm_ variant those labels should go away > return ret; > } > > @@ -1128,8 +1128,7 @@ static void exynos_tmu_remove(struct platform_device *pdev) > > clk_disable_unprepare(data->sclk); > clk_unprepare(data->clk); > - if (!IS_ERR(data->clk_sec)) > - clk_unprepare(data->clk_sec); > + clk_unprepare(data->clk_sec); > } > > #ifdef CONFIG_PM_SLEEP > -- > 2.49.0 > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog