mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frederic Weisbecker <frederic@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org,
	x86@kernel.org
Subject: Re: [tip: perf/core] perf: Fix irq work dereferencing garbage
Date: Thu, 8 May 2025 23:43:57 +0200	[thread overview]
Message-ID: <aB0lnW68rLDtuCkZ@pavilion.home> (raw)
In-Reply-To: <20250508194605.GA8552@noisy.programming.kicks-ass.net>

Le Thu, May 08, 2025 at 09:46:05PM +0200, Peter Zijlstra a écrit :
> On Thu, May 08, 2025 at 09:11:23PM +0200, Frederic Weisbecker wrote:
> > Le Thu, May 08, 2025 at 10:34:29AM -0000, tip-bot2 for Frederic Weisbecker a écrit :
> > > The following commit has been merged into the perf/core branch of tip:
> > > 
> > > Commit-ID:     88d51e795539acd08bce028eff3aa78748b847a8
> > > Gitweb:        https://git.kernel.org/tip/88d51e795539acd08bce028eff3aa78748b847a8
> > > Author:        Frederic Weisbecker <frederic@kernel.org>
> > > AuthorDate:    Mon, 28 Apr 2025 13:11:47 +02:00
> > > Committer:     Peter Zijlstra <peterz@infradead.org>
> > > CommitterDate: Fri, 02 May 2025 12:40:40 +02:00
> > > 
> > > perf: Fix irq work dereferencing garbage
> > > 
> > > The following commit:
> > > 
> > > 	da916e96e2de ("perf: Make perf_pmu_unregister() useable")
> > > 
> > > has introduced two significant event's parent lifecycle changes:
> > > 
> > > 1) An event that has exited now has EVENT_TOMBSTONE as a parent.
> > >    This can result in a situation where the delayed wakeup irq_work can
> > >    accidentally dereference EVENT_TOMBSTONE on:
> > > 
> > > CPU 0                                          CPU 1
> > 
> > This is missing the most important (and boring) part of the changelog :-)
> > 
> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > 
> > And I suspect some automatic check will also yell at some point at missing Sob.
> 
> Doh, script fail :/
> 
> Let me go fix.

Looks good, thanks!

-- 
Frederic Weisbecker
SUSE Labs

  reply	other threads:[~2025-05-08 21:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-08 10:34 tip-bot2 for Frederic Weisbecker
2025-05-08 19:11 ` Frederic Weisbecker
2025-05-08 19:46   ` Peter Zijlstra
2025-05-08 21:43     ` Frederic Weisbecker [this message]
2025-05-08 19:55 tip-bot2 for Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aB0lnW68rLDtuCkZ@pavilion.home \
    --to=frederic@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®