From: Herbert Xu <herbert@gondor.apana.org.au>
To: Klaus Kudielka <klaus.kudielka@gmail.com>
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>,
regressions@lists.linux.dev, linux-kernel@vger.kernel.org,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Boris Brezillon <bbrezillon@kernel.org>,
EBALARD Arnaud <Arnaud.Ebalard@ssi.gouv.fr>,
Romain Perier <romain.perier@gmail.com>
Subject: Re: [v3 PATCH] crypto: marvell/cesa - Do not chain submitted requests
Date: Sat, 10 May 2025 18:19:37 +0800 [thread overview]
Message-ID: <aB8oOVLJ_k2YYMzP@gondor.apana.org.au> (raw)
In-Reply-To: <41680c5d41ed568e8c65451843e3ff212fd340c4.camel@gmail.com>
On Sat, May 10, 2025 at 11:38:16AM +0200, Klaus Kudielka wrote:
>
> Patch applied on top.
> On the first attempt all self-tests passed, but on the second and third unfortunately not.
OK, you can get more consistent errors by enabling extra testing with
CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y.
In any case, let's go back to the printk approach and see what's
going on. This patch could either go on top of the previous ones
or be applied by itself.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff --git a/drivers/crypto/marvell/cesa/cesa.c b/drivers/crypto/marvell/cesa/cesa.c
index 9c21f5d835d2..fd7f43575cb2 100644
--- a/drivers/crypto/marvell/cesa/cesa.c
+++ b/drivers/crypto/marvell/cesa/cesa.c
@@ -127,6 +127,8 @@ static irqreturn_t mv_cesa_int(int irq, void *priv)
if (!(status & mask))
break;
+ pr_err("mv_cesa_int: %d 0x%x 0x%x\n", engine->id, status, mask);
+
/*
* TODO: avoid clearing the FPGA_INT_STATUS if this not
* relevant on some platforms.
diff --git a/drivers/crypto/marvell/cesa/hash.c b/drivers/crypto/marvell/cesa/hash.c
index a46ae868110a..cc7efd9a099a 100644
--- a/drivers/crypto/marvell/cesa/hash.c
+++ b/drivers/crypto/marvell/cesa/hash.c
@@ -396,6 +396,8 @@ static void mv_cesa_ahash_complete(struct crypto_async_request *req)
}
atomic_sub(ahashreq->nbytes, &engine->load);
+
+ pr_err("mv_cesa_ahash_complete: %d 0x%lx\n", engine->id, (unsigned long)ahashreq);
}
static void mv_cesa_ahash_prepare(struct crypto_async_request *req,
@@ -417,6 +419,8 @@ static void mv_cesa_ahash_req_cleanup(struct crypto_async_request *req)
struct ahash_request *ahashreq = ahash_request_cast(req);
struct mv_cesa_ahash_req *creq = ahash_request_ctx(ahashreq);
+ pr_err("mv_cesa_ahash_req_cleanup: %d 0x%lx\n", creq->base.engine->id, (unsigned long)ahashreq);
+
if (creq->last_req)
mv_cesa_ahash_last_cleanup(ahashreq);
@@ -783,6 +787,7 @@ static int mv_cesa_ahash_queue_req(struct ahash_request *req)
engine = mv_cesa_select_engine(req->nbytes);
mv_cesa_ahash_prepare(&req->base, engine);
+ pr_err("mv_cesa_ahash_queue_req: %d 0x%lx\n", engine->id, (unsigned long)req);
ret = mv_cesa_queue_req(&req->base, &creq->base);
if (mv_cesa_req_needs_cleanup(&req->base, ret))
diff --git a/drivers/crypto/marvell/cesa/tdma.c b/drivers/crypto/marvell/cesa/tdma.c
index 9b5fd957dde2..59be742c5a1c 100644
--- a/drivers/crypto/marvell/cesa/tdma.c
+++ b/drivers/crypto/marvell/cesa/tdma.c
@@ -47,6 +47,8 @@ void mv_cesa_dma_step(struct mv_cesa_req *dreq)
engine->chain_hw.last = dreq->chain.last;
spin_unlock_bh(&engine->lock);
+ pr_err("mv_cesa_dma_step: %d 0x%lx 0x%lx 0x%lx\n", engine->id, (unsigned long)dreq, (unsigned long)dreq->chain.first->cur_dma, (unsigned long)dreq->chain.last->cur_dma);
+
writel_relaxed(0, engine->regs + CESA_SA_CFG);
mv_cesa_set_int_mask(engine, CESA_SA_INT_ACC0_IDMA_DONE);
@@ -137,6 +139,7 @@ int mv_cesa_tdma_process(struct mv_cesa_engine *engine, u32 status)
int res = 0;
tdma_cur = readl(engine->regs + CESA_TDMA_CUR);
+ pr_err("mv_cesa_tdma_process: %d 0x%lx\n", engine->id, (unsigned long)tdma_cur);
for (tdma = engine->chain_hw.first; tdma; tdma = next) {
spin_lock_bh(&engine->lock);
@@ -186,6 +189,8 @@ int mv_cesa_tdma_process(struct mv_cesa_engine *engine, u32 status)
break;
}
+ pr_err("mv_cesa_tdma_process: %d %d 0x%lx\n", engine->id, res, (unsigned long)req);
+
/*
* Save the last request in error to engine->req, so that the core
* knows which request was faulty
next prev parent reply other threads:[~2025-05-10 10:19 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 11:21 [REGRESSION] alg: ahash: Several tests fail during boot on Turris Omnia Klaus Kudielka
2024-10-06 8:47 ` Klaus Kudielka
2024-10-06 9:11 ` Herbert Xu
2024-10-06 9:23 ` Klaus Kudielka
2024-10-07 8:27 ` Herbert Xu
2024-10-07 20:57 ` Klaus Kudielka
2024-10-09 8:34 ` Herbert Xu
2024-10-09 8:38 ` [PATCH] crypto: marvell/cesa - Disable hash algorithms Herbert Xu
2024-10-09 16:48 ` [REGRESSION] alg: ahash: Several tests fail during boot on Turris Omnia Klaus Kudielka
2024-10-10 6:05 ` Herbert Xu
2024-10-10 8:24 ` Herbert Xu
2024-10-10 17:35 ` Klaus Kudielka
2024-10-15 4:52 ` Herbert Xu
2024-10-15 17:38 ` Klaus Kudielka
2024-10-16 4:27 ` Herbert Xu
2024-10-16 5:51 ` Klaus Kudielka
2024-10-16 9:53 ` Herbert Xu
2024-11-12 19:33 ` Klaus Kudielka
2024-11-13 9:57 ` Thorsten Leemhuis
2025-05-06 13:19 ` Herbert Xu
2025-05-07 8:43 ` [PATCH] crypto: marvell/cesa - Do not chain submitted requests Herbert Xu
2025-05-07 15:16 ` Corentin Labbe
2025-05-08 5:15 ` [v2 PATCH] " Herbert Xu
2025-05-08 5:22 ` [v3 " Herbert Xu
2025-05-08 12:53 ` Corentin Labbe
2025-05-08 13:10 ` Herbert Xu
2025-05-08 13:43 ` Corentin Labbe
2025-05-09 3:13 ` Herbert Xu
2025-05-09 3:19 ` Herbert Xu
2025-05-09 8:11 ` Herbert Xu
2025-05-09 11:01 ` Corentin Labbe
2025-05-10 1:15 ` Herbert Xu
2025-05-10 1:37 ` Herbert Xu
2025-05-10 1:44 ` Herbert Xu
2025-05-10 10:41 ` [PATCH] crypto: marvell/cesa - Handle zero-length skcipher requests Herbert Xu
2025-05-10 8:32 ` [v3 PATCH] crypto: marvell/cesa - Do not chain submitted requests Klaus Kudielka
2025-05-10 9:05 ` Herbert Xu
2025-05-10 9:38 ` Klaus Kudielka
2025-05-10 10:19 ` Herbert Xu [this message]
2025-05-10 10:43 ` [PATCH] crypto: marvell/cesa - Avoid empty transfer descriptor Herbert Xu
2025-05-10 11:14 ` Corentin Labbe
2025-05-10 11:39 ` Herbert Xu
2025-05-10 13:02 ` Herbert Xu
2025-05-10 15:07 ` Klaus Kudielka
2025-05-11 3:22 ` Herbert Xu
2025-05-11 16:39 ` Klaus Kudielka
2025-05-13 9:20 ` Herbert Xu
2025-05-14 5:12 ` Klaus Kudielka
2025-05-14 5:14 ` Herbert Xu
2025-05-15 17:53 ` Klaus Kudielka
2025-05-15 18:21 ` Eric Biggers
2025-05-15 18:45 ` Klaus Kudielka
2025-05-15 23:25 ` Herbert Xu
2025-05-16 12:41 ` Corentin Labbe
2025-05-16 12:45 ` Herbert Xu
2025-05-17 11:24 ` Corentin Labbe
2025-05-18 7:58 ` Herbert Xu
2025-05-21 5:06 ` Herbert Xu
2025-05-21 9:16 ` Herbert Xu
2025-05-21 9:58 ` Arnd Bergmann
2025-05-21 10:24 ` Herbert Xu
2025-05-21 11:36 ` Arnd Bergmann
2025-05-22 3:13 ` Herbert Xu
2025-05-22 20:08 ` Corentin Labbe
2025-05-21 10:45 ` Corentin Labbe
2025-05-21 10:56 ` Herbert Xu
2025-05-21 13:58 ` Corentin Labbe
2025-05-22 3:01 ` crypto: marvell/cesa - dma_alloc_coherent broken but kmalloc + dma_map_single works Herbert Xu
2025-05-22 7:38 ` Herbert Xu
2025-05-22 20:07 ` Corentin Labbe
2025-05-23 11:46 ` Herbert Xu
2025-05-28 9:58 ` Herbert Xu
2025-05-29 11:17 ` Corentin Labbe
2025-05-22 11:13 ` Herbert Xu
2025-05-16 4:12 ` [PATCH] crypto: marvell/cesa - Avoid empty transfer descriptor Herbert Xu
2025-05-16 17:36 ` Klaus Kudielka
2025-06-17 5:32 ` Klaus Kudielka
2025-06-17 5:36 ` Herbert Xu
2025-05-08 12:49 ` [v2 PATCH] crypto: marvell/cesa - Do not chain submitted requests Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aB8oOVLJ_k2YYMzP@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Arnaud.Ebalard@ssi.gouv.fr \
--cc=bbrezillon@kernel.org \
--cc=clabbe.montjoie@gmail.com \
--cc=klaus.kudielka@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=regressions@lists.linux.dev \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®