From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2DC226B080 for ; Tue, 29 Apr 2025 06:51:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745909481; cv=none; b=o5wVAGvwsCkAPsfMAZOkQyak4kfaPiDl4fFO3GJmFZGPM+Ouv+N1LMHkyY+Pz2Ewq5WUvlFYj4C1RmuknsNVUILqZshA3KB7hh9cEJMwG7mEVrbwEW0TfkN9gDUP/5NaWJXCMo86/sF/uD33+qMV2ersgdoQnKmaq55yZHunM+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745909481; c=relaxed/simple; bh=ng4cdubXRoHSOfNaikV2yHk9smMLtTiFP7fxNeNmUIA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PEKo/cgE2y4UlUHXHdLAcDQjlIGl38ZVncjky90SWAxOvB4+C1qbd0ZxEH6eTRVna8KVOjki0d7g+Txv25B85Sa8fsnjaUXYk/J2+7q+QSI1SgUqHQNXhVe7iq2HDZqZCCnF3H6GZctqTefCE8NIN9lNSkpuWAp+dINJbHHwQpE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1u9eo6-0000oM-Lq; Tue, 29 Apr 2025 08:51:06 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u9eo4-000DdC-2u; Tue, 29 Apr 2025 08:51:04 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1u9eo4-00An2G-2X; Tue, 29 Apr 2025 08:51:04 +0200 Date: Tue, 29 Apr 2025 08:51:04 +0200 From: Oleksij Rempel To: Andrew Lunn Cc: "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Woojung Huh , "Russell King (Oracle)" , Heiner Kallweit , stable@vger.kernel.org, kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: Re: [PATCH net v1 1/2] net: dsa: microchip: let phylink manage PHY EEE configuration on KSZ switches Message-ID: References: <20250428125119.3414046-1-o.rempel@pengutronix.de> <20250428125119.3414046-2-o.rempel@pengutronix.de> <4d8a3e79-f454-4e2f-9362-c842354b123a@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Mon, Apr 28, 2025 at 08:07:04PM +0200, Oleksij Rempel wrote: > On Mon, Apr 28, 2025 at 06:51:19PM +0200, Andrew Lunn wrote: > > > +/** > > > + * ksz_phylink_mac_disable_tx_lpi() - Dummy handler to disable TX LPI > > > + * @config: phylink config structure > > > + * > > > + * For ports with integrated PHYs, LPI is managed internally by hardware. > > > > Could you expand that. > > > > Does it mean the hardware will look at the results of the autoneg and > > disable/enable LPI depending on those results? > > Yes. > > > I also assume this means it is not possible to force LPI on/off, independent > > of autoneg? > > Correct. set_eee call in this driver is filtering (tx_lpi == false) to > reflect HW functionality. I'll update this patch to include this information. -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |