From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Alistair Francis <alistair23@gmail.com>,
sagi@grimberg.me, kch@nvidia.com, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org, hare@suse.de,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH] nvme-tcp: select tls config when tcp tls is enabled
Date: Tue, 29 Apr 2025 10:42:09 -0700 [thread overview]
Message-ID: <aBEPcVursIG8fab6@kbusch-mbp> (raw)
In-Reply-To: <20250429125505.GA13574@lst.de>
On Tue, Apr 29, 2025 at 02:55:05PM +0200, Christoph Hellwig wrote:
> On Thu, Apr 24, 2025 at 08:13:33PM +1000, Alistair Francis wrote:
> > Ensure that TLS support is enabled in the kernel when
> > NVME_TARGET_TCP_TLS is enabled. This allows TLS secure channels to be
> > used out of the box.
>
> How did the code even build before this?
The nvme tls code doesn't appear to use any symbols that depend on
CONFIG_TLS, so I guess it would compile but wouldn't work at runtime. ?
next prev parent reply other threads:[~2025-04-29 17:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 10:13 Alistair Francis
2025-04-24 10:35 ` Hannes Reinecke
2025-04-29 12:55 ` Christoph Hellwig
2025-04-29 17:42 ` Keith Busch [this message]
2025-04-29 22:04 ` Alistair Francis
2025-04-29 13:17 ` Hannes Reinecke
2025-04-29 14:18 ` Jens Axboe
2025-04-29 16:28 ` Chaitanya Kulkarni
2025-04-29 17:35 ` Hannes Reinecke
2025-04-29 22:31 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBEPcVursIG8fab6@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®