From: Boqun Feng <boqun.feng@gmail.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: FUJITA Tomonori <fujita.tomonori@gmail.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
a.hindborg@samsung.com, frederic@kernel.org, lyude@redhat.com,
tglx@linutronix.de, anna-maria@linutronix.de, jstultz@google.com,
sboyd@kernel.org, ojeda@kernel.org, alex.gaynor@gmail.com,
gary@garyguo.net, bjorn3_gh@protonmail.com,
benno.lossin@proton.me, aliceryhl@google.com, tmgross@umich.edu,
chrisi.schrefl@gmail.com, arnd@arndb.de, linux@armlinux.org.uk
Subject: Re: [PATCH v1] rust: time: Avoid 64-bit integer division
Date: Thu, 1 May 2025 06:25:04 -0700 [thread overview]
Message-ID: <aBN2MMaxGrvhF08W@Mac.home> (raw)
In-Reply-To: <CANiq72m8RfL5g9kmAhZdZZbrpDschrXf1yJVvkWmvMzdnMaSvA@mail.gmail.com>
On Thu, May 01, 2025 at 03:22:00PM +0200, Miguel Ojeda wrote:
> On Thu, May 1, 2025 at 3:12 PM Boqun Feng <boqun.feng@gmail.com> wrote:
> >
> > #[cfg(CONFIG_ARM)]
> > fn ns_to_ms(ns: i64) -> i64 {
> >
> > #[cfg(not(CONFIG_ARM))]
> > fn ns_to_ms(ns: i64) -> i64 {
>
> I think `cfg`s may be better inside, i.e. as local as reasonably
> possible, so that we share e.g. signature as well as any attributes
> and docs.
>
Fair enough.
Regards,
Boqun
> Cheers,
> Miguel
>
next prev parent reply other threads:[~2025-05-01 13:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 1:58 FUJITA Tomonori
2025-05-01 2:45 ` FUJITA Tomonori
2025-05-01 9:24 ` Miguel Ojeda
2025-05-01 12:02 ` FUJITA Tomonori
2025-05-01 8:01 ` Christian Schrefl
2025-05-01 9:22 ` Miguel Ojeda
2025-05-01 12:26 ` Boqun Feng
2025-05-01 12:37 ` Boqun Feng
2025-05-01 13:48 ` FUJITA Tomonori
2025-05-01 14:06 ` Boqun Feng
2025-05-01 13:07 ` FUJITA Tomonori
2025-05-01 13:12 ` Boqun Feng
2025-05-01 13:20 ` Boqun Feng
2025-05-01 15:11 ` Arnd Bergmann
2025-05-01 23:03 ` Boqun Feng
2025-05-01 23:38 ` Christian Schrefl
2025-05-03 0:14 ` FUJITA Tomonori
2025-05-01 13:22 ` Miguel Ojeda
2025-05-01 13:25 ` Boqun Feng [this message]
2025-05-01 13:38 ` FUJITA Tomonori
2025-05-05 10:46 ` Andreas Hindborg
2025-05-05 11:10 ` FUJITA Tomonori
2025-05-05 11:51 ` Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBN2MMaxGrvhF08W@Mac.home \
--to=boqun.feng@gmail.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=anna-maria@linutronix.de \
--cc=arnd@arndb.de \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=chrisi.schrefl@gmail.com \
--cc=frederic@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lyude@redhat.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®