From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Richard Leitner <richard.leitner@linux.dev>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v3 8/9] media: i2c: ov9282: add strobe_duration v4l2 control
Date: Thu, 1 May 2025 22:22:38 +0000 [thread overview]
Message-ID: <aBP0Lioy6Qi0Iw66@kekkonen.localdomain> (raw)
In-Reply-To: <t7lnqmhufsyf5ygfkfyllvxpm4h2qdxotgi2lcfoxlhxjpejjd@mf2poxik2zje>
Hi Richard,
On Wed, Apr 30, 2025 at 11:09:30AM +0200, Richard Leitner wrote:
> Hi Sakari,
>
> thanks for the review!
You're welcome.
> > > + v4l2_ctrl_new_std(ctrl_hdlr, &ov9282_ctrl_ops, V4L2_CID_FLASH_DURATION,
> >
> > Should the number of controls in the handler be updated?
>
> What do you mean by "number of controls in the handler" exactly? Which
> handler?
A number of buckets allocated in control handler's initialisation is based
on the number of controls given to the init function. You should update
that number when adding controls.
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2025-05-01 22:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 12:59 [PATCH v3 0/9] Add strobe/flash duration v4l2 ctrl & use it for ov9282 Richard Leitner
2025-04-29 12:59 ` [PATCH v3 1/9] media: v4l: ctrls: add a control for flash/strobe duration Richard Leitner
2025-04-29 12:59 ` [PATCH v3 2/9] leds: flash: add support for flash/stobe duration Richard Leitner
2025-04-29 12:59 ` [PATCH v3 3/9] media: v4l2-flash: add support for flash/strobe duration Richard Leitner
2025-04-30 8:24 ` Sakari Ailus
2025-04-30 8:37 ` Richard Leitner
2025-04-30 8:41 ` Sakari Ailus
2025-04-29 12:59 ` [PATCH v3 4/9] media: v4l2-flash: fix flash_timeout comment Richard Leitner
2025-04-29 12:59 ` [PATCH v3 5/9] Documentation: uAPI: media: add V4L2_CID_FLASH_DURATION Richard Leitner
2025-04-29 12:59 ` [PATCH v3 6/9] media: i2c: ov9282: add output enable register definitions Richard Leitner
2025-04-29 12:59 ` [PATCH v3 7/9] media: i2c: ov9282: add led_mode v4l2 control Richard Leitner
2025-04-29 12:59 ` [PATCH v3 8/9] media: i2c: ov9282: add strobe_duration " Richard Leitner
2025-04-30 8:27 ` Sakari Ailus
2025-04-30 9:09 ` Richard Leitner
2025-05-01 22:22 ` Sakari Ailus [this message]
2025-05-06 9:37 ` Richard Leitner
2025-04-29 12:59 ` [PATCH v3 9/9] media: i2c: ov9282: add strobe_source " Richard Leitner
2025-04-30 8:39 ` Sakari Ailus
2025-04-30 9:15 ` Richard Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBP0Lioy6Qi0Iw66@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pavel@kernel.org \
--cc=richard.leitner@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®