From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] list: Remove redundant 'extern' for function prototypes
Date: Mon, 5 May 2025 09:55:22 +0300 [thread overview]
Message-ID: <aBhg2i7k8ZprSkCV@surfacebook.localdomain> (raw)
In-Reply-To: <20250503193542.bd707ba88b542bb797fa49b9@linux-foundation.org>
Sat, May 03, 2025 at 07:35:42PM -0700, Andrew Morton kirjoitti:
> On Fri, 2 May 2025 15:17:42 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > The 'extern' keyword is redundant for function prototypes.
> > list.h never used them and new code in general is better
> > without them.
...
> > -extern bool __list_valid_slowpath __list_del_entry_valid_or_report(struct list_head *entry);
> > +bool __list_valid_slowpath __list_del_entry_valid_or_report(struct list_head *entry);
>
> I'll apply this because you continue to do significant work on list.h
> but I don't want to spend the next 5 years buried in little "remove
> externs" patches!
Thank you!
FWIW, I made this change because (as stated in the commit message) list.h from
the beginning hasn't used that keyword and a relatively new change brought
this. It's not a part of any huge churn, and just a standalone ad-hoc change.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-05-05 6:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 12:17 Andy Shevchenko
2025-05-04 2:35 ` Andrew Morton
2025-05-05 6:55 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBhg2i7k8ZprSkCV@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®