mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: David Rhodes <david.rhodes@cirrus.com>,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH v2 2/9] ASoC: codec: cs42l56: Drop cs42l56.h
Date: Tue, 6 May 2025 07:50:50 +0900	[thread overview]
Message-ID: <aBlAys_SvQRHNTcp@finisterre.sirena.org.uk> (raw)
In-Reply-To: <20250428-csl42x-v2-2-e8056313968f@nxp.com>

[-- Attachment #1: Type: text/plain, Size: 744 bytes --]

On Mon, Apr 28, 2025 at 10:09:03AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> There is no in-tree user of "include/sound/cs42l56.h", so move
> 'struct cs42l56_platform_data' to cs42l56.c and remove the header file.
> And platform data is mostly for platforms that create
> devices non using device tree. CS42L56 is a discontinued product,
> there is less possibility that new users will use legacy method
> to create devices. So drop cs42l56.h to prepare using GPIOD API.

This breaks an x86 allmodconfig build:

/build/stage/linux/sound/soc/codecs/cs42l56.c:26:10: fatal error: 'sound/cs42l56.h' file not found
   26 | #include <sound/cs42l56.h>
      |          ^~~~~~~~~~~~~~~~~
1 error generated.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2025-05-05 22:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-28  2:09 [PATCH v2 0/9] ASoC: codec: cs42l[56,73,52]: Convert to GPIO descriptors Peng Fan (OSS)
2025-04-28  2:09 ` [PATCH v2 1/9] ASoC: codec: cs42l56: Sort headers alphabetically Peng Fan (OSS)
2025-04-28  2:09 ` [PATCH v2 2/9] ASoC: codec: cs42l56: Drop cs42l56.h Peng Fan (OSS)
2025-05-05 22:50   ` Mark Brown [this message]
2025-05-06  1:13     ` Peng Fan
2025-04-28  2:09 ` [PATCH v2 3/9] ASoC: codec: cs42l56: Convert to GPIO descriptors Peng Fan (OSS)
2025-05-13  9:13   ` Linus Walleij
2025-04-28  2:09 ` [PATCH v2 4/9] ASoC: codec: cs42l73: Sort headers alphabetically Peng Fan (OSS)
2025-04-28  2:09 ` [PATCH v2 5/9] ASoC: codec: cs42l73: Drop cs42l73.h Peng Fan (OSS)
2025-04-28  2:09 ` [PATCH v2 6/9] ASoC: codec: cs42l73: Convert to GPIO descriptors Peng Fan (OSS)
2025-05-13  9:14   ` Linus Walleij
2025-04-28  2:09 ` [PATCH v2 7/9] ASoC: codec: cs42l52: Sort headers alphabetically Peng Fan (OSS)
2025-04-28  2:09 ` [PATCH v2 8/9] ASoC: codec: cs42l52: Drop cs42l52.h Peng Fan (OSS)
2025-04-28  2:09 ` [PATCH v2 9/9] ASoC: codec: cs42l52: Convert to GPIO descriptors Peng Fan (OSS)
2025-05-13  9:14   ` Linus Walleij
2025-05-07 11:12 ` [PATCH v2 0/9] ASoC: codec: cs42l[56,73,52]: " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aBlAys_SvQRHNTcp@finisterre.sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=david.rhodes@cirrus.com \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=perex@perex.cz \
    --cc=rf@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®