From: Johan Hovold <johan@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Paul Cercueil <paul@crapouillou.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Sebastian Reichel <sre@kernel.org>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] rtc: s3c: drop unused module alias
Date: Tue, 6 May 2025 16:35:01 +0200 [thread overview]
Message-ID: <aBoeFUbBKsNoqyd7@hovoldconsulting.com> (raw)
In-Reply-To: <193c2c8c-df64-43ab-84ef-5e981fc31469@kernel.org>
On Tue, May 06, 2025 at 04:19:08PM +0200, Krzysztof Kozlowski wrote:
> On 23/04/2025 15:03, Johan Hovold wrote:
> > The driver only support OF probe so drop the unused platform module
> > alias.
> >
> > Fixes: ae05c95074e0 ("rtc: s3c: add s3c_rtc_data structure to use variant data instead of s3c_cpu_type")
>
> I believe this is not correct, but instead commit dropping last platform
> user, which I think was:
>
> Fixes: 0d297df03890 ("ARM: s3c: simplify platform code")
No, as I write in the commit message, the driver only supports OF probe
since the commit I refer to. It fails with -EINVAL and the following
error logged:
failed getting s3c_rtc_data
for non-OF probe.
> Just like in other patches here, these are old drivers and even if they
> have OF matching method, they can be or they were modprobed via board files.
See above, similar reasoning applies for the other patches.
Johan
next prev parent reply other threads:[~2025-05-06 14:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 13:03 [PATCH 0/7] rtc: " Johan Hovold
2025-04-23 13:03 ` [PATCH 1/7] rtc: at91rm9200: " Johan Hovold
2025-05-06 14:22 ` Krzysztof Kozlowski
2025-04-23 13:03 ` [PATCH 2/7] rtc: cpcap: " Johan Hovold
2025-04-23 21:30 ` Sebastian Reichel
2025-04-23 13:03 ` [PATCH 3/7] rtc: da9063: " Johan Hovold
2025-05-06 14:50 ` Krzysztof Kozlowski
2025-04-23 13:03 ` [PATCH 4/7] rtc: jz4740: " Johan Hovold
2025-04-24 10:13 ` Paul Cercueil
2025-04-23 13:03 ` [PATCH 5/7] rtc: pm8xxx: " Johan Hovold
2025-05-06 14:51 ` Krzysztof Kozlowski
2025-04-23 13:03 ` [PATCH 6/7] rtc: s3c: " Johan Hovold
2025-05-06 14:19 ` Krzysztof Kozlowski
2025-05-06 14:35 ` Johan Hovold [this message]
2025-05-06 14:45 ` Krzysztof Kozlowski
2025-04-23 13:03 ` [PATCH 7/7] rtc: stm32: " Johan Hovold
2025-05-06 14:22 ` Krzysztof Kozlowski
2025-05-20 7:33 ` [PATCH 0/7] rtc: " Johan Hovold
2025-05-24 22:03 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBoeFUbBKsNoqyd7@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=johan+linaro@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=paul@crapouillou.net \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®