From: Keith Busch <kbusch@kernel.org>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Kanchan Joshi <joshi.k@samsung.com>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: fix write_stream_granularity initialization
Date: Tue, 6 May 2025 13:09:47 -0600 [thread overview]
Message-ID: <aBpee6L-UXEDcH_h@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20250506175413.1936110-1-csander@purestorage.com>
On Tue, May 06, 2025 at 11:54:12AM -0600, Caleb Sander Mateos wrote:
> write_stream_granularity is set to max(info->runs, U32_MAX), which means
> that any RUNS value less than 2 ** 32 becomes U32_MAX, and any larger
> value is silently truncated to an unsigned int.
>
> Use min() instead to provide the correct semantics, capping RUNS values
> at U32_MAX.
>
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
> Fixes: 30b5f20bb2dd ("nvme: register fdp parameters with the block layer")
Looks good
Reviewed-by: Keith Busch <kbusch@kernel.org>
next prev parent reply other threads:[~2025-05-06 19:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 17:54 Caleb Sander Mateos
2025-05-06 19:09 ` Keith Busch [this message]
2025-05-06 19:47 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBpee6L-UXEDcH_h@kbusch-mbp.dhcp.thefacebook.com \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®