From: Keith Busch <kbusch@kernel.org>
To: Daniel Wagner <wagi@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Hannes Reinecke <hare@kernel.org>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme-pci: lock per namespace in nvme_poll_irqdisable
Date: Thu, 8 May 2025 08:28:56 -0600 [thread overview]
Message-ID: <aBy_qLi3OvYk6HAL@kbusch-mbp> (raw)
In-Reply-To: <20250508-nvme-pci-polling-v1-1-29ae900e793d@kernel.org>
On Thu, May 08, 2025 at 01:55:55PM +0200, Daniel Wagner wrote:
> + spin_lock(&nvmeq->cq_poll_lock);
> disable_irq(pci_irq_vector(pdev, nvmeq->cq_vector));
> nvme_poll_cq(nvmeq, NULL);
> enable_irq(pci_irq_vector(pdev, nvmeq->cq_vector));
> + spin_unlock(&nvmeq->cq_poll_lock);
> }
I noticed disable_irq() contains a "might_sleep()", so the order needs
to have spin_lock() happen after disable_irq().
prev parent reply other threads:[~2025-05-08 14:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 11:55 Daniel Wagner
2025-05-08 14:28 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBy_qLi3OvYk6HAL@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=wagi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®