From: Richard Cochran <richardcochran@gmail.com>
To: Jeongjun Park <aha310510@gmail.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, yangbo.lu@nxp.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ptp: remove ptp->n_vclocks check logic in ptp_vclock_in_use()
Date: Thu, 22 May 2025 05:32:15 -0700 [thread overview]
Message-ID: <aC8ZT3MW2EhPSQGK@hoboy.vegasvil.org> (raw)
In-Reply-To: <20250520160717.7350-1-aha310510@gmail.com>
On Wed, May 21, 2025 at 01:07:17AM +0900, Jeongjun Park wrote:
> There is no disagreement that we should check both ptp->is_virtual_clock
> and ptp->n_vclocks to check if the ptp virtual clock is in use.
>
> However, when we acquire ptp->n_vclocks_mux to read ptp->n_vclocks in
> ptp_vclock_in_use(), we observe a recursive lock in the call trace
> starting from n_vclocks_store().
> The best way to solve this is to remove the logic that checks
> ptp->n_vclocks in ptp_vclock_in_use().
Acked-by: Richard Cochran <richardcochran@gmail.com>
next prev parent reply other threads:[~2025-05-22 12:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 16:07 Jeongjun Park
2025-05-22 12:32 ` Richard Cochran [this message]
2025-05-22 21:50 ` Jakub Kicinski
2025-05-26 11:00 ` Jeongjun Park
2025-05-27 17:42 ` Jakub Kicinski
2025-06-04 14:10 ` Jeongjun Park
2025-06-06 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aC8ZT3MW2EhPSQGK@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=aha310510@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®