From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91F3325A32F for ; Mon, 12 May 2025 08:57:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747040242; cv=none; b=drGpjSMqXo+ofZLJR4ysRwHme6Yx5vCYG07sj2usMPvT48Tn+PdGQr3RaoA7fA1CSoMy4l5jTwAFTAosKuZAxQC8EVSS2AZtLSR6OMKh7pB71QWWe0WPKgKOtVkAU6mbNDSvkSj3+GlVes5o/7XBpqKgWxvC92dFMOEUqCNQRq0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747040242; c=relaxed/simple; bh=JhLyS8OlAvaLP9r7KbQp2hC6ezEHKIzbqXNmUbZHJpI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Nc5mbRL6Al6c3oNWIWB2qp/POD9EPzh0kHRDDZgDIlLRdeXeqelJObYZUTwEsCGXVFjPfKxzX9UPvoepzjB6+oGsckKQIhGMfHzbdlv4seg40+bexdL7lCVaUDPPerjf7LCssBu8Qj7nDg+Do/eoMLzWC3g1LAkSfigpRcCkSTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=D1Uaidzq; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="D1Uaidzq" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-74068f95d9fso3779214b3a.0 for ; Mon, 12 May 2025 01:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1747040240; x=1747645040; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Sc3CqNV/8Mi2zP04knLd5VAdkGEl8lYzJxAs+HQXCEQ=; b=D1UaidzqpoK8gIulW9n1/Bsx8Ekb5WoxuQhpfF1z5uBRux3hsCDFNo7zNHYqBGDgZl CeuQ1ux0KNKMYNODDa+mV5+KkseMK8cJpdf7QNhrawYkjidcIVpNH1BdKcuohzpkUbhW H6OPN+E6uxWcZ8TiyAaooZbZvVbgrPO/+dx6xiqDCUywjer71y4j6E02z++N7wVyozLc Tu2vclbwMDZawKoou3vuUNFLo2pZL/r2FZn+y7dZuGppA3bis57GWmW3mZGVoFrEc6sn UPAYt6fOdNkIMqa8bLneDh4oVgiKEsxVpti/1u+LdyY14pvc+1BrWXQ0IAfzDtVRFeGy 7kpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747040240; x=1747645040; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Sc3CqNV/8Mi2zP04knLd5VAdkGEl8lYzJxAs+HQXCEQ=; b=n89w4wjjw28O4JC21l+yEfYF8b0K6hTRhzpJl7K/oMIJ2KurmQInYiVAJTZZjoaj2s qRHUkEV/SLAbvQyrZzbbtk5f35WG6E+vzJJY7DVaAGxUrzAPQeVJgwsbPdZcx1NCcWoB WJjV0CWDbiIimdtDaxj+zxbXa61aL4nSINw2Kh/iiNfuH2fOhI9KuyewzM10cMIHqrZj InBK6fDyLxlMU5O3NlTv6HGnsQBqR0gfuRE9CPFEGtsVqo248TfliVVGfYHO97A4YpMz oV5auaNysORGqG6YhVYrzen4wK9gJf+pXjWvisZUhoVyOPqDS2Fo7DTE4fE/85xNrY4E ATTg== X-Forwarded-Encrypted: i=1; AJvYcCX+zpDoRHj2Bg6f9MhDlmHp87dYNvf4LtBlLt8gtACyccRRKRPEX3/uyDg2ac/46b6LKT9PukZVzTxEFnI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/e/QAYMeMXLVm4Km9hv8if0x13lgMH9yWLvJ8ewN7SDZD4Df6 DXuHdeS4CO6eYWEi3CumqUS4J/DA9NJ7iDDoHUED9iggbtqix00KGHXzUXZNik0= X-Gm-Gg: ASbGncu5tgqo6yhLSCymSd0IlPM08azUAtXkSR7GDQbR7JD/t/d8cVgyhX+73T1Jwe5 NOgrfpTuOcrlsz8EfxYk64U8ohAcqwfTeqYDlI+qrV/61UEKGTUcTTZ8JWQDT/8JaiGsPbX2HJA juEj+V1kCItH3doQn3lbZ5RN0Q4xZepXYnOY5Z08pIh7GrgKXLvme3bQba+pX2SzPF8CaURp2Lg +jYpwMBcf4bUHuwnhh9TJpg6ECD2tAb7UvBB/vOEuuC/QRLBmv906ZUsCQzKa9dijekDfb0BHrc YXGqUzhiHUmQ/g/471qb+RfjR/reeabEhe3HXCiz2UtorqlgcXdVRcp4FK8= X-Google-Smtp-Source: AGHT+IFWgBjdZaW68l9bQibLY9baPAwDqAl5/2YWyRVkP0+/oKFF3fyXGC7vyJbnIM52riOnSv7fSQ== X-Received: by 2002:a05:6a20:8792:b0:215:d4be:b0ad with SMTP id adf61e73a8af0-215d4beb697mr3485599637.28.1747040239872; Mon, 12 May 2025 01:57:19 -0700 (PDT) Received: from sunil-laptop ([103.97.166.196]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b234a0b29casm4459423a12.28.2025.05.12.01.57.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 01:57:19 -0700 (PDT) Date: Mon, 12 May 2025 14:27:05 +0530 From: Sunil V L To: Andy Shevchenko Cc: Anup Patel , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jassi Brar , Thomas Gleixner , "Rafael J . Wysocki" , Mika Westerberg , Linus Walleij , Bartosz Golaszewski , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Palmer Dabbelt , Paul Walmsley , Len Brown , Rahul Pathak , Leyfoon Tan , Atish Patra , Andrew Jones , Samuel Holland , Anup Patel , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 20/23] mailbox/riscv-sbi-mpxy: Add ACPI support Message-ID: References: <20250511133939.801777-1-apatel@ventanamicro.com> <20250511133939.801777-21-apatel@ventanamicro.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, May 12, 2025 at 11:47:14AM +0300, Andy Shevchenko wrote: > On Mon, May 12, 2025 at 02:06:37PM +0530, Sunil V L wrote: > > On Mon, May 12, 2025 at 10:28:17AM +0300, Andy Shevchenko wrote: > > > On Sun, May 11, 2025 at 07:09:36PM +0530, Anup Patel wrote: > > ... > > > > > +#ifdef CONFIG_ACPI > > > > + if (!acpi_disabled) > > > > > > Hmm... Why do you need this check? What for? > > > > > When we boot with DT, ACPI_COMPANION(dev) will return NULL which will > > cause a crash in acpi_dev_clear_dependencies(). Let me know if I am > > missing something. > > Yes, just check that the companion is NULL, rather than the above. > > struct acpi_device *adev; > > adev = ACPI_COMPANION(dev); > if (adev) > acpi_dev_clear_dependencies(adev); > Ah Ok. Sure. Will update. Thanks! Sunil