From: Herbert Xu <herbert@gondor.apana.org.au>
To: Borislav Petkov <bp@alien8.de>
Cc: Jain@formenos.rohan.me.apana.org.au, Ayush <Ayush.Jain3@amd.com>,
Stephen Rothwell <sfr@canb.auug.org.au>, x86-ml <x86@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
linux-crypto@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: [PATCH] crypto: lib/sha256 - Disable SIMD
Date: Fri, 16 May 2025 19:48:52 +0800 [thread overview]
Message-ID: <aCcmJGuCnuyHmHbx@gondor.apana.org.au> (raw)
In-Reply-To: <aCcirrsFFrrRqf5A@gondor.apana.org.au>
On Fri, May 16, 2025 at 07:34:06PM +0800, Herbert Xu wrote:
>
> So what's happened is that previously if you call sha256_update
> from lib/crypto it would only use the generic C code to perform
> the operation.
>
> This has now been changed to automatically use SIMD instructions
> which obviously blew up in your case.
In the interim you can go back to the old ways and disable SIMD
for lib/crypto sha256 with this patch:
---8<---
Disable SIMD usage in lib/crypto sha256 as it is causing crashes.
Reported-by: Borislav Petkov <bp@alien8.de>
Fixes: 950e5c84118c ("crypto: sha256 - support arch-optimized lib and expose through shash")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/include/crypto/internal/sha2.h b/include/crypto/internal/sha2.h
index b9bccd3ff57f..e1b0308c0539 100644
--- a/include/crypto/internal/sha2.h
+++ b/include/crypto/internal/sha2.h
@@ -32,7 +32,7 @@ static inline void sha256_choose_blocks(
if (!IS_ENABLED(CONFIG_CRYPTO_ARCH_HAVE_LIB_SHA256) || force_generic)
sha256_blocks_generic(state, data, nblocks);
else if (IS_ENABLED(CONFIG_CRYPTO_ARCH_HAVE_LIB_SHA256_SIMD) &&
- (force_simd || crypto_simd_usable()))
+ force_simd)
sha256_blocks_simd(state, data, nblocks);
else
sha256_blocks_arch(state, data, nblocks);
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-05-16 11:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 11:22 cryptodev linux-next splat Borislav Petkov
2025-05-16 11:34 ` Herbert Xu
2025-05-16 11:48 ` Herbert Xu [this message]
2025-05-16 12:27 ` [PATCH] crypto: lib/sha256 - Disable SIMD Borislav Petkov
2025-05-16 17:03 ` Eric Biggers
2025-05-16 18:13 ` Borislav Petkov
2025-05-16 19:06 ` Eric Biggers
2025-05-16 20:34 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCcmJGuCnuyHmHbx@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Ayush.Jain3@amd.com \
--cc=Jain@formenos.rohan.me.apana.org.au \
--cc=bp@alien8.de \
--cc=ebiggers@google.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®