From: Andy Shevchenko <andy@kernel.org>
To: Lothar Rubusch <l.rubusch@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
corbet@lwn.net, lucas.p.stankus@gmail.com, lars@metafoo.de,
Michael.Hennerich@analog.com, linux-iio@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 06/12] iio: accel: adxl313: prepare interrupt handling
Date: Mon, 19 May 2025 14:48:45 +0300 [thread overview]
Message-ID: <aCsanRq9xYvSIYVR@smile.fi.intel.com> (raw)
In-Reply-To: <20250518111321.75226-7-l.rubusch@gmail.com>
On Sun, May 18, 2025 at 11:13:15AM +0000, Lothar Rubusch wrote:
> Evaluate the devicetree property for an optional interrupt line, and
> configure the interrupt mapping accordingly. When no interrupt line
> is defined in the devicetree, keep the FIFO in bypass mode as before.
...
> +#define ADXL313_INT_NONE 0
Hmm... I would rather make it U8_MAX, but it's up to you.
> +#define ADXL313_INT1 1
> +#define ADXL313_INT2 2
...
> + /* FIFO_STREAM mode */
> + regval = int_line == ADXL313_INT2 ? 0xff : 0;
One space too many.
> + ret = regmap_write(data->regmap, ADXL313_REG_INT_MAP, regval);
Don't you want to use regmap_assign_bits() or something like this to have
the above ternary be included?
> + if (ret)
> + return ret;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-05-19 11:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-18 11:13 [PATCH v1 00/12] iio: accel: adxl313: add power-save on activity/inactivity Lothar Rubusch
2025-05-18 11:13 ` [PATCH v1 01/12] iio: accel: adxl313: add debug register Lothar Rubusch
2025-05-18 11:13 ` [PATCH v1 02/12] iio: accel: adxl313: introduce channel scan_index Lothar Rubusch
2025-05-19 10:46 ` Andy Shevchenko
2025-05-18 11:13 ` [PATCH v1 03/12] iio: accel: adxl313: configure scan type for buffer Lothar Rubusch
2025-05-18 11:13 ` [PATCH v1 04/12] iio: accel: adxl313: make use of regmap cache Lothar Rubusch
2025-05-18 11:13 ` [PATCH v1 05/12] iio: accel: adxl313: add function to enable measurement Lothar Rubusch
2025-05-18 11:13 ` [PATCH v1 06/12] iio: accel: adxl313: prepare interrupt handling Lothar Rubusch
2025-05-19 11:48 ` Andy Shevchenko [this message]
2025-05-18 11:13 ` [PATCH v1 07/12] iio: accel: adxl313: add basic " Lothar Rubusch
2025-05-19 11:59 ` Andy Shevchenko
2025-05-18 11:13 ` [PATCH v1 08/12] iio: accel: adxl313: add FIFO watermark Lothar Rubusch
2025-05-18 11:13 ` [PATCH v1 09/12] iio: accel: adxl313: add activity sensing Lothar Rubusch
2025-05-19 12:15 ` Andy Shevchenko
2025-05-18 11:13 ` [PATCH v1 10/12] iio: accel: adxl313: add inactivity sensing Lothar Rubusch
2025-05-19 12:17 ` Andy Shevchenko
2025-05-18 11:13 ` [PATCH v1 11/12] iio: accel: adxl313: implement power-save on inactivity Lothar Rubusch
2025-05-19 12:19 ` Andy Shevchenko
2025-05-18 11:13 ` [PATCH v1 12/12] docs: iio: add ADXL313 accelerometer Lothar Rubusch
2025-05-20 19:32 [PATCH v1 06/12] iio: accel: adxl313: prepare interrupt handling Lothar Rubusch
2025-05-20 19:49 ` Andy Shevchenko
2025-05-25 11:26 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCsanRq9xYvSIYVR@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=corbet@lwn.net \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=l.rubusch@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.p.stankus@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®