From: Johan Hovold <johan@kernel.org>
To: "Dominik Karol Piątkowski" <dominik.karol.piatkowski@protonmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 RESEND 0/6] USB: serial: ftdi_sio: Code style cleanup
Date: Mon, 19 May 2025 14:26:44 +0200 [thread overview]
Message-ID: <aCsjhIbX5iT3ZALw@hovoldconsulting.com> (raw)
In-Reply-To: <20250414202750.9013-1-dominik.karol.piatkowski@protonmail.com>
On Mon, Apr 14, 2025 at 08:28:10PM +0000, Dominik Karol Piątkowski wrote:
> This series fixes spotted code style issues in ftdi_sio driver.
> Dominik Karol Piątkowski (6):
> USB: serial: ftdi_sio: Remove space before comma
> USB: serial: ftdi_sio: Add missing blank line after declarations
> USB: serial: ftdi_sio: Remove superfluous space before statements
> USB: serial: ftdi_sio: Fix indentation made with spaces
> USB: serial: ftdi_sio: Fix misaligned block comment
> USB: serial: ftdi_sio: Remove space before tabs
You should not be running checkpatch.pl (as you've clearly done here) on
code that's already in the kernel.
The exception is drivers/staging where patches like these are welcome so
that new contributers can practise on creating patches.
Johan
prev parent reply other threads:[~2025-05-19 12:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 20:28 Dominik Karol Piątkowski
2025-04-14 20:28 ` [PATCH v2 RESEND 1/6] USB: serial: ftdi_sio: Remove space before comma Dominik Karol Piątkowski
2025-04-14 20:28 ` [PATCH v2 RESEND 2/6] USB: serial: ftdi_sio: Add missing blank line after declarations Dominik Karol Piątkowski
2025-04-14 20:28 ` [PATCH v2 RESEND 3/6] USB: serial: ftdi_sio: Remove superfluous space before statements Dominik Karol Piątkowski
2025-04-14 20:28 ` [PATCH v2 RESEND 4/6] USB: serial: ftdi_sio: Fix indentation made with spaces Dominik Karol Piątkowski
2025-04-14 20:28 ` [PATCH v2 RESEND 5/6] USB: serial: ftdi_sio: Fix misaligned block comment Dominik Karol Piątkowski
2025-04-14 20:28 ` [PATCH v2 RESEND 6/6] USB: serial: ftdi_sio: Remove space before tabs Dominik Karol Piątkowski
2025-05-19 12:26 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCsjhIbX5iT3ZALw@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=dominik.karol.piatkowski@protonmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®