Re: (subset) [PATCH v6 00/10] drm/display: generic HDMI CEC helpers

[Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>]

Hi Biju, Dmitry,

On Fri, May 23, 2025 at 03:47:24PM +0200, Tommaso Merciai wrote:
> Hi Biju, Dmitry,
> Thanks for your comments.
> 
> On Fri, May 23, 2025 at 09:37:19AM +0300, Dmitry Baryshkov wrote:
> > Hi Biju
> > 
> > On Fri, 23 May 2025 at 09:17, Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > >
> > > Hi Dmitry Baryshkov,
> > >
> > > Thanks for the series.
> > >
> > > Looks like, After this patch, when I change resolution using modetest it is not working.
> > > Monitor is showing out of range/No signal on RZ/V2L SMARC EVK connected to ADV7535.
> > >
> > > Not sure, I am the only one facing this issue?
> 
> I have the same issue using RZ/G3E Smark EVK connected to ADV7535.
> I found that switching back to the old:
> 
>  - adv7511_mode_set()
>  - Using also old .mode_set = adv7511_bridge_mode_set,
> 
> Implementation fix the issue on my side.

Diving a bit on this issue I'm seeing the following:

root@smarc-rzg3e:~# modetest -M rzg2l-du -d -s HDMI-A-1:800x600-56.25@XR24
setting mode 800x600-56.25Hz on connectors HDMI-A-1, crtc 62
[   49.273134] adv7511_mode_set_old: drm_mode_vrefresh(mode) = 56
[   49.281006] rzg2l_mipi_dsi_atomic_enable: mode->clock: 36000

root@smarc-rzg3e:~# modetest -M rzg2l-du -d -s HDMI-A-1:800x600-56.25@XR24
setting mode 800x600-56.25Hz on connectors HDMI-A-1, crtc 62
[   74.076881] rzg2l_mipi_dsi_atomic_enable: mode->clock: 36000
[   74.092130] adv7511_mode_set: drm_mode_vrefresh(adj_mode) = 56

Same result but I think bad timing:

 - old: adv7511_mode_set() is call before rzg2l_mipi_dsi_atomic_enable()
 - new: adv7511_mode_set() is call after rzg2l_mipi_dsi_atomic_enable()

What do you think? Thanks in advance.

Thanks & Regards,
Tommaso

> 
> Thanks & Regards,
> Tommaso
> 
> > 
> > I have been testing the series on db410c / adv7533, but something
> > might have changed between the testing time and the present time. I
> > will try checking it next week.
> > 
> > In the meantime, you can probably try comparing what gets programmed
> > in adv7511_mode_set().
> > 
> > >
> > > Modetest works fine with 6.15.0-rc6-next-20250516, where this patch series is
> > > not present.
> > >
> > > Cheers,
> > > Biju
> > >
> > > > -----Original Message-----
> > > > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Dmitry Baryshkov
> > > > Sent: 20 May 2025 23:40
> > > > Subject: Re: (subset) [PATCH v6 00/10] drm/display: generic HDMI CEC helpers
> > > >
> > > >
> > > > On Sat, 17 May 2025 04:59:36 +0300, Dmitry Baryshkov wrote:
> > > > > Currently it is next to impossible to implement CEC handling for the
> > > > > setup using drm_bridges and drm_bridge_connector: bridges don't have a
> > > > > hold of the connector at the proper time to be able to route CEC events.
> > > > >
> > > > > At the same time it not very easy and obvious to get the CEC physical
> > > > > address handling correctly. Drivers handle it at various places,
> > > > > ending up with the slight differences in behaviour.
> > > > >
> > > > > [...]
> > > >
> > > > Applied, thanks!
> > > >
> > > > [01/10] drm/bridge: move private data to the end of the struct
> > > >         commit: fa3769e09be76142d51c617d7d0c72d9c725a49d
> > > > [02/10] drm/bridge: allow limiting I2S formats
> > > >         commit: d9f9bae6752f5a0280a80d1bc524cabd0d60c886
> > > > [03/10] drm/connector: add CEC-related fields
> > > >         commit: e72cd597c35012146bfe77b736a30fee3e77e61e
> > > > [04/10] drm/display: move CEC_CORE selection to DRM_DISPLAY_HELPER
> > > >         commit: bcc8553b6228d0387ff64978a03efa3c8983dd2f
> > > > [05/10] drm/display: add CEC helpers code
> > > >         commit: 8b1a8f8b2002d31136d83e4d730b4cb41e9ee868
> > > > [06/10] drm/display: hdmi-state-helper: handle CEC physical address
> > > >         commit: 603ce85427043ecb29ef737c1b350901ce3ebf09
> > > > [08/10] drm/display: bridge-connector: hook in CEC notifier support
> > > >         commit: 65a2575a68e4ff03ba887b5aef679fc95405fcd2
> > > > [09/10] drm/display: bridge-connector: handle CEC adapters
> > > >         commit: a74288c8ded7c34624e50b4aa8ca37ae6cc03df4
> > > > [10/10] drm/bridge: adv7511: switch to the HDMI connector helpers
> > > >         commit: ae01d3183d2763ed27ab71f4ef5402b683d9ad8a
> > > >
> > > > Best regards,
> > > > --
> > > > Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> > >
> > 
> > 
> > -- 
> > With best wishes
> > Dmitry
>