From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Abdulrasaq Lawani <abdulrasaqolawani@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Jonathan Corbet <corbet@lwn.net>
Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] drm: add overview diagram for drm stack
Date: Mon, 26 May 2025 08:51:48 +0700 [thread overview]
Message-ID: <aDPJNBTDmHoZ-z1d@archie.me> (raw)
In-Reply-To: <20250523-drm-doc-updates-v2-2-e517df152cf6@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3994 bytes --]
On Fri, May 23, 2025 at 03:52:26PM -0400, Abdulrasaq Lawani wrote:
> diff --git a/Documentation/gpu/introduction.rst b/Documentation/gpu/introduction.rst
> index 91bb0efc96d69921a122c5265b1431fa18110a7a..2653048ad4bb0ecbc2b676295440442dddbabae6 100644
> --- a/Documentation/gpu/introduction.rst
> +++ b/Documentation/gpu/introduction.rst
> @@ -15,41 +15,43 @@ and the new vblank internals, in addition to all the regular features
> found in current kernels.
>
> Overview of the Linux DRM Architecture
> ------------------------------------------------
> -+-----------------------------+
> -| User-space Apps |
> -| (Games, Browsers, ML, etc.) |
> -+-----------------------------+
> - |
> - v
> -+---------------------------------------+
> -| Graphics APIs | Compute APIs |
> -| (OpenGL, Vulkan) | (OpenCL, CUDA) |
> -+---------------------------------------+
> - | |
> - v v
> -+---------------------+ +-----------------------+
> -| User-space Driver | | Compute Runtime |
> -| (Mesa, AMD/NVIDIA) | | (OpenCL, CUDA, ROCm) |
> -+---------------------+ +-----------------------+
> - | |
> - +--------+----------+
> - |
> - v
> - +-----------------------+
> - | libdrm (DRM API) |
> - +-----------------------+
> - |
> - v
> -+-------------------------------------------+
> -| Kernel DRM/KMS Driver (i915, amdgpu, |
> -| nouveau, etc.) |
> -+-------------------------------------------+
> - | |
> - v v
> -+----------------+ +-------------------+
> -| GPU Display HW | | GPU Compute Units |
> -+----------------+ +-------------------+
> +======================================
Why promoting the section heading?
> +::
> +
> + +-----------------------------+
> + | User-space Apps |
> + | (Games, Browsers, ML, etc.) |
> + +-----------------------------+
> + |
> + v
> + +---------------------------------------+
> + | Graphics APIs | Compute APIs |
> + | (OpenGL, Vulkan) | (OpenCL, CUDA) |
> + +---------------------------------------+
> + | |
> + v v
> + +---------------------+ +-----------------------+
> + | User-space Driver | | Compute Runtime |
> + | (Mesa, AMD/NVIDIA) | | (OpenCL, CUDA, ROCm) |
> + +---------------------+ +-----------------------+
> + | |
> + +--------+----------+
> + |
> + v
> + +-----------------------+
> + | libdrm (DRM API) |
> + +-----------------------+
> + |
> + v
> + +-------------------------------------------+
> + | Kernel DRM/KMS Driver (i915, amdgpu, |
> + | nouveau, etc.) |
> + +-------------------------------------------+
> + | |
> + v v
> + +----------------+ +-------------------+
> + | GPU Display HW | | GPU Compute Units |
> + +----------------+ +-------------------+
>
This is not how reviews from v1 should be addressed. Instead of making
separate commit for review suggestions, you need to squash them into affected
commit(s) in v1. In this case, there should be only one resulting patch. Don't
forget to send it as v3.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2025-05-26 1:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 19:52 [PATCH v2 0/2] " Abdulrasaq Lawani
2025-05-23 19:52 ` [PATCH v2 1/2] " Abdulrasaq Lawani
2025-05-23 19:52 ` [PATCH v2 2/2] " Abdulrasaq Lawani
2025-05-26 1:51 ` Bagas Sanjaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDPJNBTDmHoZ-z1d@archie.me \
--to=bagasdotme@gmail.com \
--cc=abdulrasaqolawani@gmail.com \
--cc=airlied@gmail.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®