From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7E9521D3D1 for ; Thu, 29 May 2025 14:39:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748529562; cv=none; b=CT4h5wLC+VR+zCRlTxGm2aoP2EVDek4mZgnP5nvXOeKD8t+hQ+VnRKUc70uZwHK3DnjGm6OCoszk2ZOk25joP6YbU8KRHayVmN++RkBehOdZ1nIbFK62XFcUT6Apmw2jgy9zuieRJNW1EIN5pMF2+FSLcfyW5L8+zK05PV6gncE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748529562; c=relaxed/simple; bh=AV3ES5YCbjV4DWcsEdH3BBLXaARTJL41ZMtZqz9w4rc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=T19ZXCOy0auIyzYSbG7QbIwjMCI/0pofXDWDGPwGqA74hzF/LYBtQdC3SLk5xZMyHcANXdRYi/6Ai3QLORLxTPC3owgSCi7oPdKJirrx5s4EFb8z1cyx6HAU7aCjWIFPn+BmXgnEvVscobeEx/dFEyLuPfo28buEoM4M/1KLou8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hRvjffPp; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hRvjffPp" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-311cc665661so952100a91.2 for ; Thu, 29 May 2025 07:39:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748529559; x=1749134359; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=xNU4esLQTJeSc9s6NX0+57EwpHiPvJrGTCr/LKvOY+E=; b=hRvjffPp7cX3NTKCIK03c0yQL4Ap3t8Mp22HJT3clV9U2KmRZtaQvC72eaFBPsdrgZ AsEi97dRVKYaeYX53tLZ4vI2cc8ClsP773bri/dAYbsCNuBLQRa5ToUpC5NSocbMkQmv OQMzLjiFFCkDb1MqkzHjFqRW2zXGpjCTotxAD17cm16nelh42IjcCZnU97NA3T8MDLwE nkpiaInPIEl53HPTYqNDBr2S9nsJFdZruFNRV1dwKaUNOs49trrSsWToZr4yy+dzW0Fv 20vrqQnQ2rHTUgmZOU/Y/txpgc0oU0qSWvaUHARthgoJ04cq6agFEjdy8fobl/BaWy/d bMkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748529559; x=1749134359; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xNU4esLQTJeSc9s6NX0+57EwpHiPvJrGTCr/LKvOY+E=; b=Kd5FOR0Rafy/dpl0OakcREF7AY06HuxE1tQFBeYfooBeX1ly8rcta79MBbpZPm54/I 4fgTYepPgJBWYL4qqFPTzlvsyxsPnGE0u8Ds6ZhuaOSvsXOwaDS0L/seqp6+3PFEtV8c CnJpeq7v7/uk3lB4ooZEo6Hha4p3qdP8PfhKr0Eg650XNCGLVsz8sRBbT2C/VRcN3Bk0 HA7aI8N1sPWkdX071bl4RRHYilFBvNsUc99s9YFAbJocfgdcKXAPUKRT7eti6MrsjV/P hcOAv8lZHfzjgqW7r3OFpM5UUwQGviAOOJnf4TSvSfQnyf31t8s7mNC7TX7SIaULYF3H Rf4g== X-Forwarded-Encrypted: i=1; AJvYcCVct6eVLYpu0f59ExgYYY8+VG9VBwEh1bSk8fAWEGXAC56K+WaOsi3pEck85mYQOU78ju0+3SEUS8He20I=@vger.kernel.org X-Gm-Message-State: AOJu0YwVHVwAaqDJOb/5YmF4Ekk3voe0rfwbdQpHmfS0Z+09+wSEcBSC 42em1Ph1poM6BCASX6M4ucu3Xxxdkj7zrSb7fJo+jkYkIYSjIwId75edlHOSNkw1ZG2VXu7b3Uj SPSfDLA== X-Google-Smtp-Source: AGHT+IEPLUlO0bEM312C1lkvzSJg3YO38HianJoHmgjrLk4H4zuj1AahrI8DhoIW4Ey8GMjYyXU3U8s+f5o= X-Received: from pjbsz13.prod.google.com ([2002:a17:90b:2d4d:b0:30e:7d59:f3a7]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:3d02:b0:312:25dd:1c86 with SMTP id 98e67ed59e1d1-31225dd1debmr2792026a91.18.1748529558530; Thu, 29 May 2025 07:39:18 -0700 (PDT) Date: Thu, 29 May 2025 07:39:16 -0700 In-Reply-To: <100ec82b37b7ce523a12b81623613b71e72c8ba0.camel@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250519232808.2745331-1-seanjc@google.com> <20250519232808.2745331-5-seanjc@google.com> <100ec82b37b7ce523a12b81623613b71e72c8ba0.camel@intel.com> Message-ID: Subject: Re: [PATCH 04/15] KVM: x86: Drop superfluous kvm_hv_set_sint() => kvm_hv_synic_set_irq() wrapper From: Sean Christopherson To: Kai Huang Cc: "pbonzini@redhat.com" , "vkuznets@redhat.com" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" On Thu, May 29, 2025, Kai Huang wrote: > On Mon, 2025-05-19 at 16:27 -0700, Sean Christopherson wrote: > > Drop the superfluous kvm_hv_set_sint() and instead wire up ->set() directly > > to its final destination. > > kvm_hv_set_sint() is still there after this patch. Did you mean "superfluous > kvm_hv_synic_set_irq()"? :-) Ugh, yeah, bad changelog. Maybe this? Rename kvm_hv_synic_set_irq() to kvm_hv_set_sint() and drop the previous incarnation of kvm_hv_set_sint() provided by irq_comm.c, which is just a wrapper to the hyperv.c code. That said, given that the tracepoint is trace_kvm_hv_synic_set_irq(), and that the IOAPIC and PIC versions are kvm_ioapic_set_irq() and kvm_pic_set_irq() respectively, I'm leaning towards a straight drop of kvm_hv_set_sint(), i.e. keep kvm_hv_synic_set_irq().