From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E68A272E41 for ; Thu, 5 Jun 2025 13:50:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749131458; cv=none; b=vCoyOxrdD8JKDuS5sjcCVSnBvIEjabe7E2ja3usPqaKtecVyHwoVc2MqsGeBpDCkzpNrgvVocd9N3DX3G27u9aVO+y2tft1N0CcQHkovzS6/ykQ96PxJBKl53YoOSSzkuXzehP3jjBi2yUITfI4B6VumdiKl0HxGhz/+pnoyCGc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749131458; c=relaxed/simple; bh=pGhX/wVZN0RGvBVwSNXI+HlZVCiN3e9tQXYEg1OIFho=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=j6JKbGG8hJGv5WnwcjGcm6R0W1ECA9eU8wvFzENlSrBFepOzEVtTo/CFlGD6Y/llohJfSOV7NFtsw1C6NHX3AfUIOXRvs3SD6OJ9SOVzEPhvzfOOxtV1c4gYYRZvV595f9XjYOacdPYeUcClSNb8vjHtRxk6TUyCcIIDGvtmJts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=LxqEvHXJ; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="LxqEvHXJ" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-601f278369bso2016267a12.1 for ; Thu, 05 Jun 2025 06:50:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749131455; x=1749736255; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=ggZCkgQEfMCBTbPPekOLvTIApHTIQLiYr/IDAMWkO24=; b=LxqEvHXJLYk18bGojUrSLXq17kg7fltNrkO3UaA1AFcH2GbiI1eui22s/l6ekjeMX8 U0qiCZZ6Ay6LrYnyuJ18iuQIjZiF1vEGuBGankf8vkdBZBk7qTNO247haDL0jwUL3eHP XwHc5Vmw1tP5pTDCkmXFqM1n6FgPz7L3mZ0K9Ml001YWaGW2J7ZvrkwCPV0nkoWv93Vl y5sDrPL27oxg/hg48BoYip8H+7oMpFWmjev4Sy/HjqKfVSH1VXZel+0/77VX3/KsMhzm 45eBu4xreuHYW5V4Ondzg2e32GjHi4AN+GfEpP2z02zBOwvGxWGrwegzkPz6tvlSNwek KjgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749131455; x=1749736255; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ggZCkgQEfMCBTbPPekOLvTIApHTIQLiYr/IDAMWkO24=; b=JSFuJaxsB3NoDoWHQTEB7ANgc2QL1EBuu50vnCBOm7hIJ1zUNpvYkXpRUnxS2vRIa7 +tPQg9bYRKUiAYZ6b260nIVkXmzL1znj6Ej+q7O89E3OJ2vqfGbsWEtIur8VyKeRBNqg an4RIMwrkdwsmpwbBm0jEfs8vPCN2Y98sbbYqA235NV3sITyo9MwgeQC6flNpXdNXCZ4 P13VBn9i/LvIlbwF+3SDnB7JehhZeLvBCvii2/W7eWjmHLArJ6coMvfz+CVBR5rFUj9L PY+dBCoD8lCdnK7GxJhD0OGwBwU88FVVwO2g+2blUtyt+18w2Etpw6kKF6IBxSdIsYdI eJAA== X-Forwarded-Encrypted: i=1; AJvYcCXFpKtdI/p7bUl7+R6WFHc5sppH6e38DcA1PpGQ4Ln/+sP6lcnZCNZfAk++pnuMaC/UOOctddMhVx9zuVY=@vger.kernel.org X-Gm-Message-State: AOJu0YxGbVf7rESbJS+6vQfl10jQf6BQnxLWpW4ZJdNp/68gFtEww4gS nHocc1yXflbQngcF7R2ZHnJVw+NbGmAx5pBq8nRxeNOFXA6n/+Mdl+JpSfIxyZ3ZryY= X-Gm-Gg: ASbGncv5ttGtZjgcEYx50xQarzTpVwVxn3PidwvgGnP92j82//C4pWSuRVf6mSFWlWC e6XyJ58HX3QxF4MjUA4JbtBjb33vSeWw1cWY4Trp9Lkjz81bldfLblk1oOOBrKee0Nw+moB6Y9L ZC1wlp3MiBgzTVukxIH7a+9ISqbO/itU7FBEfnckY5pPaXc5TDWVIVQpK6DYdUPJRj3ZMmITaDn T8UoYp4vviyr4Su1mRdV21NUe4LqFZwpMpCRouO6ZQr8iE3KCRusZUgZUZdAXcUlmSbdqP0Eigi 9NK3DkpgaLTizz0hue3kCrEmxh5edx0igl1HGFzDYdc+pRxbIxgJ2DnR+bc1EF3z9qZvOHlIlDF ZYnnopqwk4nEz7PBR7de5uFP2NC8M6pQ2JzDCXpm8VmQ= X-Google-Smtp-Source: AGHT+IGsZK01GTgeXRGvrF2f+PIjoQHuluhsLAHTkeb0wTJPNILx+jwsb/VHsmQ9utQ5doDtE/qnrQ== X-Received: by 2002:a17:906:7951:b0:adb:41b1:feca with SMTP id a640c23a62f3a-addf8ff443cmr600103066b.61.1749131454652; Thu, 05 Jun 2025 06:50:54 -0700 (PDT) Received: from localhost (host-87-21-228-106.retail.telecomitalia.it. [87.21.228.106]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ada5d82e760sm1275872866b.52.2025.06.05.06.50.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jun 2025 06:50:54 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Thu, 5 Jun 2025 15:52:31 +0200 To: Florian Fainelli Cc: Randy Dunlap , Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , Andrea della Porta , linux-clk@vger.kernel.org Subject: Re: linux-next: Tree for Jun 3 (clk/clk-rp1.c) Message-ID: References: <20250603170058.5e1e1058@canb.auug.org.au> <6e88587d-f426-4841-b370-b46917822212@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e88587d-f426-4841-b370-b46917822212@broadcom.com> On 20:06 Wed 04 Jun , Florian Fainelli wrote: > > > On 6/3/2025 10:01 AM, Randy Dunlap wrote: > > > > > > On 6/3/25 12:00 AM, Stephen Rothwell wrote: > > > Hi all, > > > > > > Please do not add any material destined for v6.17 to you rlinux-next > > > included branches until after v6.16-rc1 has been released. > > > > > > Changes since 20250530: > > > > > > > on i386: > > > > ld: drivers/clk/clk-rp1.o: in function `rp1_pll_divider_set_rate': > > clk-rp1.c:(.text+0xba1): undefined reference to `__udivdi3' > > > > caused by > > /* must sleep 10 pll vco cycles */ > > ndelay(10ULL * div * NSEC_PER_SEC / parent_rate); > > > > > > Andrea, do you mind fixing this build error for a 32-bit kernel? Thanks! Sorry for the delay, this should fix it: @@ -754,7 +769,7 @@ static int rp1_pll_divider_set_rate(struct clk_hw *hw, clockman_write(clockman, data->ctrl_reg, sec); /* must sleep 10 pll vco cycles */ - ndelay(10ULL * div * NSEC_PER_SEC / parent_rate); + ndelay(div64_ul(10ULL * div * NSEC_PER_SEC, parent_rate)); sec &= ~PLL_SEC_RST; clockman_write(clockman, data->ctrl_reg, sec); should I send a new patch with this fix only (against linux-next or stblinux/next?) or Florian is it better if you make the change in your next branch directly? Many thanks, Andrea > -- > Florian >