From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: linux@treblig.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: Remove unused ucsi_cci_str
Date: Mon, 9 Jun 2025 13:16:11 +0300 [thread overview]
Message-ID: <aEa0ayPAAqgjprEm@kuha.fi.intel.com> (raw)
In-Reply-To: <20250609004319.209143-1-linux@treblig.org>
On Mon, Jun 09, 2025 at 01:43:19AM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> ucsi_cci_str() last use was removed in 2019 by
> commit 2ede55468ca8 ("usb: typec: ucsi: Remove the old API")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/ucsi/trace.c | 17 -----------------
> drivers/usb/typec/ucsi/trace.h | 1 -
> 2 files changed, 18 deletions(-)
>
> diff --git a/drivers/usb/typec/ucsi/trace.c b/drivers/usb/typec/ucsi/trace.c
> index 596a9542d401..13a38422743a 100644
> --- a/drivers/usb/typec/ucsi/trace.c
> +++ b/drivers/usb/typec/ucsi/trace.c
> @@ -33,23 +33,6 @@ const char *ucsi_cmd_str(u64 raw_cmd)
> return ucsi_cmd_strs[(cmd >= ARRAY_SIZE(ucsi_cmd_strs)) ? 0 : cmd];
> }
>
> -const char *ucsi_cci_str(u32 cci)
> -{
> - if (UCSI_CCI_CONNECTOR(cci)) {
> - if (cci & UCSI_CCI_ACK_COMPLETE)
> - return "Event pending (ACK completed)";
> - if (cci & UCSI_CCI_COMMAND_COMPLETE)
> - return "Event pending (command completed)";
> - return "Connector Change";
> - }
> - if (cci & UCSI_CCI_ACK_COMPLETE)
> - return "ACK completed";
> - if (cci & UCSI_CCI_COMMAND_COMPLETE)
> - return "Command completed";
> -
> - return "";
> -}
> -
> static const char * const ucsi_recipient_strs[] = {
> [UCSI_RECIPIENT_CON] = "port",
> [UCSI_RECIPIENT_SOP] = "partner",
> diff --git a/drivers/usb/typec/ucsi/trace.h b/drivers/usb/typec/ucsi/trace.h
> index 41701dee7056..9554a0207276 100644
> --- a/drivers/usb/typec/ucsi/trace.h
> +++ b/drivers/usb/typec/ucsi/trace.h
> @@ -10,7 +10,6 @@
> #include <linux/usb/typec_altmode.h>
>
> const char *ucsi_cmd_str(u64 raw_cmd);
> -const char *ucsi_cci_str(u32 cci);
> const char *ucsi_recipient_str(u8 recipient);
>
> DECLARE_EVENT_CLASS(ucsi_log_command,
> --
> 2.49.0
--
heikki
prev parent reply other threads:[~2025-06-09 10:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 0:43 linux
2025-06-09 10:16 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEa0ayPAAqgjprEm@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@treblig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®