From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
Cc: Sylvain Petinot <sylvain.petinot@foss.st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] media: i2c: vd55g1: Fix RATE macros not being expressed in bps
Date: Tue, 10 Jun 2025 09:01:53 +0000 [thread overview]
Message-ID: <aEf0gdJ0hA2dNQoH@kekkonen.localdomain> (raw)
In-Reply-To: <20250609-fix_vd55g1-v1-1-594f1134e3fb@foss.st.com>
On Mon, Jun 09, 2025 at 03:46:21PM +0200, Benjamin Mugnier wrote:
> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> ---
> drivers/media/i2c/vd55g1.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c
> index 25e2fc88a0367bf6a28bb22d209323ace99299f2..78dd22d9cab03edf4ff3e5a301f8d045e930c997 100644
> --- a/drivers/media/i2c/vd55g1.c
> +++ b/drivers/media/i2c/vd55g1.c
> @@ -129,8 +129,8 @@
> #define VD55G1_FWPATCH_REVISION_MINOR 9
> #define VD55G1_XCLK_FREQ_MIN (6 * HZ_PER_MHZ)
> #define VD55G1_XCLK_FREQ_MAX (27 * HZ_PER_MHZ)
> -#define VD55G1_MIPI_RATE_MIN (250 * HZ_PER_MHZ)
> -#define VD55G1_MIPI_RATE_MAX (1200 * HZ_PER_MHZ)
> +#define VD55G1_MIPI_RATE_MIN (250 * MEGA)
> +#define VD55G1_MIPI_RATE_MAX (1200 * MEGA)
As the meaning of Hz is just /s, I don't think the use of HZ_PER_MHZ was
wrong in any way above.
--
Sakari Ailus
next prev parent reply other threads:[~2025-06-10 9:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 13:46 [PATCH 0/4] media: i2c: vd55g1: Miscellaneous fixes Benjamin Mugnier
2025-06-09 13:46 ` [PATCH 1/4] media: i2c: vd55g1: Fix RATE macros not being expressed in bps Benjamin Mugnier
2025-06-10 9:01 ` Sakari Ailus [this message]
2025-06-10 9:31 ` Benjamin Mugnier
2025-06-12 6:24 ` Sakari Ailus
2025-06-12 14:35 ` Benjamin Mugnier
2025-06-09 13:46 ` [PATCH 2/4] media: i2c: vd55g1: Fix return code in vd55g1_enable_streams error path Benjamin Mugnier
2025-06-09 13:46 ` [PATCH 3/4] media: i2c: vd55g1: Setup sensor external clock before patching Benjamin Mugnier
2025-06-09 13:46 ` [PATCH 4/4] media: i2c: vd55g1: Use first index of mbus codes array as default Benjamin Mugnier
2025-06-10 9:04 ` Sakari Ailus
2025-06-10 9:31 ` Benjamin Mugnier
2025-06-10 9:41 ` Sakari Ailus
2025-06-10 9:00 ` [PATCH 0/4] media: i2c: vd55g1: Miscellaneous fixes Sakari Ailus
2025-06-10 9:31 ` Benjamin Mugnier
2025-06-10 9:39 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEf0gdJ0hA2dNQoH@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sylvain.petinot@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®