mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juri Lelli <juri.lelli@redhat.com>
To: Yuri Andriaccio <yurand2000@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	linux-kernel@vger.kernel.org,
	Luca Abeni <luca.abeni@santannapisa.it>,
	Yuri Andriaccio <yuri.andriaccio@santannapisa.it>
Subject: Re: [RFC PATCH 5/9] sched/deadline: Hierarchical scheduling with DL on top of RT
Date: Tue, 10 Jun 2025 10:45:57 +0200	[thread overview]
Message-ID: <aEfwxUyu54Y1EXJI@jlelli-thinkpadt14gen4.remote.csb> (raw)
In-Reply-To: <20250605071412.139240-6-yurand2000@gmail.com>

Hello,

On 05/06/25 09:14, Yuri Andriaccio wrote:
> From: luca abeni <luca.abeni@santannapisa.it>
> 
> Implement the hierarchical scheduling mechanism:
> - Enforce the runtime of RT tasks controlled by cgroups using the dl_server
>   mechanism, based on the runtime and period (the deadline is set equal
>   to the period) parameters.
> - Make sched_dl_entity store the cgroups' RT local runqueue, and provide a
>   rt_rq for this runqueue.
> - Allow zeroing the runtime of a rt cgroups.
> 
> Update dl_server code:
> - Make check for the return value of dl_server_apply_params on initialization
>   of the fair server.
> - Initialize the dl_server in dl_server_start only if it is a fair server, but
>   do not initialize other types of servers, regardless of its period value.
> - Make inc_dl_task and dec_dl_task increase/decrease by one the value of active
>   tasks if a fair_server starts/stops, while ignore rt-cgroups dl_servers in
>   the accounting.
> 
> Co-developed-by: Alessio Balsini <a.balsini@sssup.it>
> Signed-off-by: Alessio Balsini <a.balsini@sssup.it>
> Co-developed-by: Andrea Parri <parri.andrea@gmail.com>
> Signed-off-by: Andrea Parri <parri.andrea@gmail.com>
> Co-developed-by: Yuri Andriaccio <yurand2000@gmail.com>
> Signed-off-by: Yuri Andriaccio <yurand2000@gmail.com>
> Signed-off-by: luca abeni <luca.abeni@santannapisa.it>
> ---
>  kernel/sched/autogroup.c |   4 +-
>  kernel/sched/core.c      |  15 +-
>  kernel/sched/deadline.c  | 145 ++++++++++++--
>  kernel/sched/rt.c        | 415 ++++++++++++++++++++++++++-------------
>  kernel/sched/sched.h     |  59 +++++-
>  kernel/sched/syscalls.c  |   4 +-
>  6 files changed, 471 insertions(+), 171 deletions(-)

From changelog (and confirmed by changed lines), this patch might be
doing too many things at once and so it might be harder to review. Do
you think it can be split in smaller chunks?

Thanks,
Juri


  reply	other threads:[~2025-06-10  8:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-05  7:14 [RFC PATCH 0/9] Hierarchical Constant Bandwidth Server Yuri Andriaccio
2025-06-05  7:14 ` [RFC PATCH 1/9] sched/deadline: Do not access dl_se->rq directly Yuri Andriaccio
2025-06-05  7:14 ` [RFC PATCH 2/9] sched/deadline: Make a distinction between dl_rq and my_q Yuri Andriaccio
2025-06-05  7:14 ` [RFC PATCH 3/9] sched/rt: Pass an rt_rq instead of an rq where needed Yuri Andriaccio
2025-06-05  7:14 ` [RFC PATCH 4/9] sched/rt: Move some inline functions from rt.c to sched.h Yuri Andriaccio
2025-06-05  7:14 ` [RFC PATCH 5/9] sched/deadline: Hierarchical scheduling with DL on top of RT Yuri Andriaccio
2025-06-10  8:45   ` Juri Lelli [this message]
2025-06-11 13:54     ` Yuri Andriaccio
2025-06-13 15:25       ` Steven Rostedt
2025-06-05  7:14 ` [RFC PATCH 6/9] sched/rt: Remove unused code Yuri Andriaccio
2025-06-05  7:14 ` [RFC PATCH 7/9] sched/core: Cgroup v2 support Yuri Andriaccio
2025-06-05  7:14 ` [RFC PATCH 8/9] sched/rt: Remove support for cgroups-v1 Yuri Andriaccio
2025-06-10  8:40   ` Juri Lelli
2025-06-05  7:14 ` [RFC PATCH 9/9] sched/deadline: Allow deeper hierarchies of RT cgroups Yuri Andriaccio
2025-06-10  9:22   ` Juri Lelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEfwxUyu54Y1EXJI@jlelli-thinkpadt14gen4.remote.csb \
    --to=juri.lelli@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.abeni@santannapisa.it \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=yurand2000@gmail.com \
    --cc=yuri.andriaccio@santannapisa.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®