mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yeoreum Yun <yeoreum.yun@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: catalin.marinas@arm.com, pcc@google.com, will@kernel.org,
	anshuman.khandual@arm.com, joey.gouly@arm.com, maz@kernel.org,
	oliver.upton@linux.dev, frederic@kernel.org,
	hardevsinh.palaniya@siliconsignals.io, samuel.holland@sifive.com,
	palmer@rivosinc.com, charlie@rivosinc.com,
	thiago.bauermann@linaro.org, bgray@linux.ibm.com,
	tglx@linutronix.de, puranjay@kernel.org, david@redhat.com,
	yang@os.amperecomputing.com, mbenes@suse.cz,
	joel.granados@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 7/7] kselftest/arm64/mte: add MTE_STORE_ONLY testcases
Date: Wed, 11 Jun 2025 15:11:25 +0100	[thread overview]
Message-ID: <aEmOja7F5afmuosj@e129823.arm.com> (raw)
In-Reply-To: <c613b941-063e-450f-a38f-c16248e95e81@sirena.org.uk>

Hi Mark,

> On Wed, Jun 11, 2025 at 10:48:02AM +0100, Yeoreum Yun wrote:
>
> > @@ -144,7 +178,7 @@ static int check_file_memory_mapping(int mem_type, int mode, int mapping, int ta
> >  			close(fd);
> >  			return KSFT_FAIL;
> >  		}
> > -		result = check_mte_memory(ptr, sizes[run], mode, tag_check, atag_check);
> > +		result = check_mte_memory(ptr, sizes[run], mode, tag_check, atag_check, tag_op);
> >  		mte_clear_tags((void *)ptr, sizes[run]);
> >  		munmap((void *)map_ptr, map_size);
> >  		close(fd);
>
> check_file_memory_mapping() looks like it also has the issue from the
> other series with skips being upgraded to fails, looks like there's more
> instances.

Thanks. I've fixed this in
  - https://lore.kernel.org/all/20250611135818.31070-10-yeoreum.yun@arm.com/

> > @@ -106,11 +115,11 @@ int main(void)
> >  	int i;
> >
> >  	ksft_print_header();
> > -	ksft_set_plan(5);
> > +	ksft_set_plan(8);
> >
>
> This should probably have been ARRAY_SIZE() to start off with, sorry.

Okay. I'll fix this.


--
Sincerely,
Yeoreum Yun

      reply	other threads:[~2025-06-11 14:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11  9:47 [PATCH v5 0/7] support FEAT_MTE_STORE_ONLY feature Yeoreum Yun
2025-06-11  9:47 ` [PATCH v5 1/7] arm64/cpufeature: add MTE_STORE_ONLY feature Yeoreum Yun
2025-06-11 14:14   ` Mark Brown
2025-06-11  9:47 ` [PATCH v5 2/7] prtcl: introduce PR_MTE_STORE_ONLY Yeoreum Yun
2025-06-11 14:14   ` Mark Brown
2025-06-11  9:47 ` [PATCH v5 3/7] arm64/kernel: support store-only mte tag check Yeoreum Yun
2025-06-11 13:19   ` Mark Brown
2025-06-11  9:47 ` [PATCH v5 4/7] arm64/hwcaps: add MTE_STORE_ONLY hwcaps Yeoreum Yun
2025-06-11  9:48 ` [PATCH v5 5/7] tools/kselftest: add MTE_STORE_ONLY feature hwcap test Yeoreum Yun
2025-06-11 12:46   ` Mark Brown
2025-06-11 14:09     ` Yeoreum Yun
2025-06-11  9:48 ` [PATCH v5 6/7] kselftest/arm64/mte: preparation for mte store only test Yeoreum Yun
2025-06-11 13:10   ` Mark Brown
2025-06-11 14:12     ` Yeoreum Yun
2025-06-11  9:48 ` [PATCH v5 7/7] kselftest/arm64/mte: add MTE_STORE_ONLY testcases Yeoreum Yun
2025-06-11 13:02   ` Mark Brown
2025-06-11 14:11     ` Yeoreum Yun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEmOja7F5afmuosj@e129823.arm.com \
    --to=yeoreum.yun@arm.com \
    --cc=anshuman.khandual@arm.com \
    --cc=bgray@linux.ibm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=charlie@rivosinc.com \
    --cc=david@redhat.com \
    --cc=frederic@kernel.org \
    --cc=hardevsinh.palaniya@siliconsignals.io \
    --cc=joel.granados@kernel.org \
    --cc=joey.gouly@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=mbenes@suse.cz \
    --cc=oliver.upton@linux.dev \
    --cc=palmer@rivosinc.com \
    --cc=pcc@google.com \
    --cc=puranjay@kernel.org \
    --cc=samuel.holland@sifive.com \
    --cc=tglx@linutronix.de \
    --cc=thiago.bauermann@linaro.org \
    --cc=will@kernel.org \
    --cc=yang@os.amperecomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®