From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92C4023643F for ; Wed, 11 Jun 2025 18:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749667466; cv=none; b=bz2NHx8AgZ22fEXtKj8d3HPvBLz26FRxxW3XmdeRCx8XNzci3z4brE/AWKaC6RRaO6tlnh+pUUVQO+s/1c67B140b6UrJlJI08spfAtnyCDg928M6K7+620aXC8OLAn+cAClCYomcL3m+hLVrS+6IESIKYiRifB844WxpmF32qA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749667466; c=relaxed/simple; bh=rW9AYnao7epI6DSNNsNbXeG46uk1hDnvTmVoKXHljtI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FNViUKyV8s58yYg5cHE/I4E15P0QXLseolk6J1JxqL9fFCGfQnf5bNixTs3B8pcA/1QyPIrRLD13DcqTbrAXjsZwd2XybxXmsKYM1H72u0yYNZICPl8mhqWOmwe3lif189fXasBxhscn2mQZinEt8CJnd6F0OKf+2XGu8v4A06s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mfZDiv2f; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mfZDiv2f" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-450dd065828so752605e9.2 for ; Wed, 11 Jun 2025 11:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749667463; x=1750272263; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=b8Z7wa9sbPXA5dzp8SGUkYWXsK6DxzHA1Tojy5Vy9ow=; b=mfZDiv2fFm+ACiWLDuOXvI4+iJQJBIWPo7yKU8UK55o0P+Xd8iven6WI7No0EW91AS 2FaJc3OxwU6D7sd7wZt2A962Ge77twubdXeBMYTBC87tYVNp+OjmSr9sQnK/K5Ask+gx fZon7+vZaIcJFJ07ZOoHbJ12/1ifHsUSHpSX45h6agTn9jDnr+QOiahuwlw36kVGyGeZ 7WpIAY2z4Wv/+vKPIwHPjTyyOAoPKp7MBpgxQ4x5bA1iXn/y8GkFhAZ088oL5T1xnqPX WrfpelGwhWRTVMtPCWiSpVkS1SAiUXFNKRo+aLW0Mc+Xj+ac7B7QeDPA6vn4V3xTTqw3 6jDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749667463; x=1750272263; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b8Z7wa9sbPXA5dzp8SGUkYWXsK6DxzHA1Tojy5Vy9ow=; b=STlfChDL0RvXuAhbMBbLDGNI+ZjItZQTCbv5cB4CKBP5Oon59yqM13hM3jSNCl8pZY ljZrX1h8GhkEO7hu5XGBQZeCKNwz+GeCKKixyBScrArQGFjufiBPEqkMr+4zaNMn1TaI RLugp7Me8oIo0Iafc8G9hhk8qnk8ztWJI2AcqmvUA4FTKk8qDyYKDXwe0vu/vXnMb3hT ta5M6rJRj42DPnsUjziAbuXz/h2dSe8vNKnT23H29XK1KAS/hg0UCO88TR828h7DqXpl J4i5ccTaD5l4RPDhpIIJfjFtDSROWDjs8Qy+nhlP/7zZYqnmTRb957lv7SaOZwXkHOkq JEGQ== X-Forwarded-Encrypted: i=1; AJvYcCVJkUK9KgGWzX8GHP/okOJq+2BRjwKTorJJvjoeW+hCE27JcYTBHmvHk2eXDk7XCxnMRWsnr0b4GpXGDWA=@vger.kernel.org X-Gm-Message-State: AOJu0YzVlYtbP4bD56gs2lVUvawwCh2seqTw3NltOjzFsIBlGiOhaMNv aBXWJZGYTg1C4HtfdwnGL2qLxxCRCTjDEqCNmQVAHEAKTDMocowNqaqZyCgZVUEAank= X-Gm-Gg: ASbGnctM0oUDz81QzspzkwHuj7VVGbgozJcme3K+P9UtFe2uzg7GPlTWNvpKlrMs3R1 n8XbuMdjHA6Cp1zFzcW0bJnuCQhzWxSAyUY4gPTjQpDN3+ldXBKqjkHlalOy7Qr+LHEbBwqnZyF DaW1ASRD6REZRew63SJkvrakH8DtA7M8dfT6R2bnSS+m8Y5QRuv7DnMd0SmVlpnPNMMxGUEfbYz 8M7XtFXXYGTfxuZck7VHzwnub0EvgRKAHL7oe3RAlxdGKmRLNguTdQvqXYeNawLpIrm/CJvlQGl aD8nlpRwVDVlrI5CTU0+ug+yC2CAZEnvHqKQ0TT4utHGbuJ4Cw9S7YNlzLpyR+WE7Rk= X-Google-Smtp-Source: AGHT+IFG5n+JZ+POBoHmw+qc3E80yBwZHeBiwkYm45+ICWtt0Wje2BpvjDKUU1DHUI4PN2DGbGjVOw== X-Received: by 2002:a05:600c:8b26:b0:450:d367:c385 with SMTP id 5b1f17b1804b1-4532b9079cdmr10409495e9.16.1749667462950; Wed, 11 Jun 2025 11:44:22 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4532513e27fsm29150025e9.1.2025.06.11.11.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 11:44:22 -0700 (PDT) Date: Wed, 11 Jun 2025 21:44:19 +0300 From: Dan Carpenter To: Karan Tilak Kumar Cc: sebaddel@cisco.com, arulponn@cisco.com, djhawar@cisco.com, gcboffa@cisco.com, mkai2@cisco.com, satishkh@cisco.com, aeasi@cisco.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, jmeneghi@redhat.com, revers@redhat.com Subject: Re: [PATCH 4/5] scsi: fnic: Turn off FDMI ACTIVE flags on link down Message-ID: References: <20250611183033.4205-1-kartilak@cisco.com> <20250611183033.4205-4-kartilak@cisco.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250611183033.4205-4-kartilak@cisco.com> On Wed, Jun 11, 2025 at 11:30:32AM -0700, Karan Tilak Kumar wrote: > When the link goes down and comes up, FDMI requests are not sent out > anymore. > Fix bug by turning off FNIC_FDMI_ACTIVE when the link goes down. > > Reviewed-by: Sesidhar Baddela > Reviewed-by: Arulprabhu Ponnusamy > Reviewed-by: Gian Carlo Boffa > Reviewed-by: Arun Easi > Tested-by: Karan Tilak Kumar > Signed-off-by: Karan Tilak Kumar > --- Fixes tag etc. regards, dan carpenter