mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Joe Damato <joe@dama.to>, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-team@meta.com
Subject: Re: [PATCH net-next 2/2] netdevsim: collect statistics at RX side
Date: Thu, 12 Jun 2025 11:04:45 -0700	[thread overview]
Message-ID: <aEsWvciIxKqlD2W8@gmail.com> (raw)
In-Reply-To: <20250612074503.1f80b816@kernel.org>

On Thu, Jun 12, 2025 at 07:45:03AM -0700, Jakub Kicinski wrote:
> On Thu, 12 Jun 2025 17:25:52 +0300 Joe Damato wrote:
> > It "feels" like other drivers would be bumping RX stats in their NAPI poll
> > function (which is nsim_poll, the naming of the functions is a bit confusing
> > here), so it seems like netdevsim maybe should too?
> 
> Good point, and then we should probably add the queue length to
> rx_dropped in nsim_queue_free() before we call purge?

Thanks Joe and Jakub, and after a review, I agree it might be a better
approach. I will update this patch with this new approach
and send a v2 tomorrow.

Thanks for the review,
--breno

      reply	other threads:[~2025-06-12 18:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11 15:06 [PATCH net-next 0/2] netdevsim: implement RX statistics using NETDEV_PCPU_STAT_DSTATS Breno Leitao
2025-06-11 15:06 ` [PATCH net-next 1/2] netdevsim: migrate to dstats stats collection Breno Leitao
2025-06-12 14:12   ` Joe Damato
2025-06-11 15:06 ` [PATCH net-next 2/2] netdevsim: collect statistics at RX side Breno Leitao
2025-06-12 14:25   ` Joe Damato
2025-06-12 14:45     ` Jakub Kicinski
2025-06-12 18:04       ` Breno Leitao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEsWvciIxKqlD2W8@gmail.com \
    --to=leitao@debian.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=joe@dama.to \
    --cc=kernel-team@meta.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®