mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Santos <Jonathan.Santos@analog.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	andy@kernel.org, nuno.sa@analog.com,
	Michael.Hennerich@analog.com, marcelo.schmitt@analog.com,
	jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, marcelo.schmitt1@gmail.com,
	linus.walleij@linaro.org, brgl@bgdev.pl, lgirdwood@gmail.com,
	broonie@kernel.org, jonath4nns@gmail.com, dlechner@baylibre.com,
	Pop Paul <paul.pop@analog.com>
Subject: Re: [PATCH v11 10/11] iio: adc: ad7768-1: add filter type and oversampling ratio attributes
Date: Fri, 13 Jun 2025 15:44:47 +0300	[thread overview]
Message-ID: <aEwdP9Tu4TvguUmI@smile.fi.intel.com> (raw)
In-Reply-To: <cd3b60c44847d5c35cecc4385bbda6533be6825e.1749569957.git.Jonathan.Santos@analog.com>

On Wed, Jun 11, 2025 at 08:51:50AM -0300, Jonathan Santos wrote:
> Separate filter type and decimation rate from the sampling frequency
> attribute. The new filter type attribute enables sinc3, sinc3+rej60
> and wideband filters, which were previously unavailable.
> 
> Previously, combining decimation and MCLK divider in the sampling
> frequency obscured performance trade-offs. Lower MCLK divider
> settings increase power usage, while lower decimation rates reduce
> precision by decreasing averaging. By creating an oversampling
> attribute, which controls the decimation, users gain finer control
> over performance.
> 
> The addition of those attributes allows a wider range of sampling
> frequencies and more access to the device features. Sampling frequency
> table is updated after every digital filter parameter change.
> 
> Changes in the sampling frequency are not allowed anymore while in
> buffered mode.

...

> +	/*
> +	 * The SINC3_DEC_RATE value is a 13-bit value split across two
> +	 * registers: MSB [12:8] and LSB [7:0]. Prepare the 13-bit value using
> +	 * FIELD_PREP and store it with the right endianness in dec_rate_reg.

FIELD_PREP()

> +	 */

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-06-13 12:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11 11:49 [PATCH v11 00/11] iio: adc: ad7768-1: Add features, improvements, and fixes Jonathan Santos
2025-06-11 11:49 ` [PATCH v11 01/11] dt-bindings: trigger-source: add generic GPIO trigger source Jonathan Santos
2025-06-11 11:50 ` [PATCH v11 02/11] dt-bindings: iio: adc: ad7768-1: document regulator provider property Jonathan Santos
2025-06-11 11:50 ` [PATCH v11 03/11] dt-bindings: iio: adc: ad7768-1: Document GPIO controller Jonathan Santos
2025-06-11 11:50 ` [PATCH v11 04/11] dt-bindings: iio: adc: ad7768-1: add trigger-sources property Jonathan Santos
2025-06-11 11:50 ` [PATCH v11 05/11] iio: adc: ad7768-1: add regulator to control VCM output Jonathan Santos
2025-06-11 11:50 ` [PATCH v11 06/11] iio: adc: ad7768-1: Add GPIO controller support Jonathan Santos
2025-06-11 11:51 ` [PATCH v11 07/11] iio: adc: ad7768-1: add multiple scan types to support 16-bits mode Jonathan Santos
2025-06-11 11:51 ` [PATCH v11 08/11] iio: adc: ad7768-1: add support for Synchronization over SPI Jonathan Santos
2025-06-11 11:51 ` [PATCH v11 09/11] iio: adc: ad7768-1: replace manual attribute declaration Jonathan Santos
2025-06-11 11:51 ` [PATCH v11 10/11] iio: adc: ad7768-1: add filter type and oversampling ratio attributes Jonathan Santos
2025-06-13 12:44   ` Andy Shevchenko [this message]
2025-06-11 11:52 ` [PATCH v11 11/11] iio: adc: ad7768-1: add low pass -3dB cutoff attribute Jonathan Santos
2025-06-13 12:47   ` Andy Shevchenko
2025-06-17 16:17     ` Jonathan Santos
2025-06-17 20:17       ` Andy Shevchenko
2025-07-06  9:33       ` Jonathan Cameron
2025-06-13 12:48 ` [PATCH v11 00/11] iio: adc: ad7768-1: Add features, improvements, and fixes Andy Shevchenko
2025-06-14 11:38   ` Jonathan Cameron
2025-07-02 11:49     ` Jonathan Santos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEwdP9Tu4TvguUmI@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=Jonathan.Santos@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=jonath4nns@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=marcelo.schmitt@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=paul.pop@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®