From: Sean Christopherson <seanjc@google.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Alexandre Chartre <alexandre.chartre@oracle.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
pbonzini@redhat.com, xiaoyao.li@intel.com, x86@kernel.org,
boris.ostrovsky@oracle.com, Jim Mattson <jmattson@google.com>
Subject: Re: [PATCH] kvm/x86: ARCH_CAPABILITIES should not be advertised on AMD
Date: Thu, 26 Jun 2025 08:44:56 -0700 [thread overview]
Message-ID: <aF1q-O_1FnNDLzWK@google.com> (raw)
In-Reply-To: <aF1ntuyr8gHleCwA@char.us.oracle.com>
On Thu, Jun 26, 2025, Konrad Rzeszutek Wilk wrote:
> On Thu, Jun 26, 2025 at 07:02:00AM -0700, Sean Christopherson wrote:
> > And it's not like KVM is forcing userspace to enumerate support for
> > ARCH_CAPABILITIES, e.g. QEMU's named AMD configs don't enumerate support. So
> > while I completely agree KVM's behavior is odd and annoying for userspace to deal
> > with, this is probably something that should be addressed in userspace.
>
> If you do -cpu host we tack this on all the time.
Yes, I know.
> Or you saying we should have QEMU disable this for AMD CPUs all the time?
Maybe not _all_ the time. But yes, I'm suggesting that QEMU clear ARCH_CAPABILITIES
when running on AMD.
> Which in effect is the same thing as doing this patch.. but just moving
> it to QEMU, kvm-tool, Google Cloud user-space thingie, AWS cloud thingie.
I don't think kvm-tool supports Windows, and I highly doubt any cloud provider
is doing the equivalent of QEMU's `-cpu host`. I.e. I suspect QEMU is the only
VMM that's actually affected by this.
> That is a lot more complexity than doing it in the kernel.
I have a hard time believing it'd be more complex. More code, probably. But
this isn't all that complex.
next prev parent reply other threads:[~2025-06-26 15:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 12:57 Alexandre Chartre
2025-06-26 14:02 ` Sean Christopherson
2025-06-26 15:31 ` Konrad Rzeszutek Wilk
2025-06-26 15:44 ` Sean Christopherson [this message]
2025-06-26 16:08 ` Jim Mattson
2025-06-26 19:22 ` Alexandre Chartre
2025-06-27 5:41 ` Xiaoyao Li
2025-06-27 6:23 ` Alexandre Chartre
2025-06-27 20:57 ` Konrad Rzeszutek Wilk
2025-07-07 20:25 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF1q-O_1FnNDLzWK@google.com \
--to=seanjc@google.com \
--cc=alexandre.chartre@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jmattson@google.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®