From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C68DE73451 for ; Tue, 17 Jun 2025 06:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750142854; cv=none; b=dIL/R5MeI7zNyTzNE6fxumgMloLh6FofG6xnJGFzJ73mUaLToj31dOABNSC5hkw9oOVHt0gOsByBrUGRI5Jc83QDfI27HbA8bF+AiHDQ9vwn9QhDhm+MF0LEZG1wSb+XQG78pGI6fJxcYx3A0bq+wMnUymdBDlNQvEjc0eSuKow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750142854; c=relaxed/simple; bh=uU9hFzaDOTZHD5p3PSB8mgjSUPP2zTLYjpfXx6AvUC4=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VEurfl6H4m0+pVPvOEiavode9y2QcbqnHGENNiqjAfUUteu+CjAInhQ0VO5w0HQYQjvYHMZgKakTglpQyTm1oK+CYTuEko+Y1LXioViOcIa+9AYGkKu+nkzPnRGg35vUm7tpunszcrfH0TLBknJ9OiAh0LFFouEw9s1iYI/KY8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eF4S37tb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eF4S37tb" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55GHX5VP002743 for ; Tue, 17 Jun 2025 06:47:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=Jzr9HurUhduvjFSlxdJqGDlJ e2HOuYisi/7N0azKI4o=; b=eF4S37tbYiuC25HjDz3vsroDP2wKXIssYQZ2HB6u Sv/OaLaI5gj5aIJGbteEIVLqeUG9CCTq3OBfb4l2qOkKuYChqErEEZrSTvXzSskM dmMcX/o8+h4kOKYAGJePDz5zWs6LJ7qkf0wn+SxvdW++JNAlUBCGbX/ixJLMFkjp YOE36XxrbxD8GYw00wq+9qVUI8jMFi9cN79N6M+oks+dPbbCmSnErBnxXgchVlxb XbyM8lMdqrNP/eU8jrdiE0aHpsf6vtAc1AYuYkdtc8Tp1UgZGyZR/W3+mFENg8VA 9PBCc7XDM7mW4UuHRXLmmAKukIM3AfM2kYvMgOj1wkPg1w== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47ag2339qn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 17 Jun 2025 06:47:31 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6fb2910dd04so97051386d6.0 for ; Mon, 16 Jun 2025 23:47:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750142851; x=1750747651; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Jzr9HurUhduvjFSlxdJqGDlJe2HOuYisi/7N0azKI4o=; b=HCtV5e+hB1YPtsUEsSPKQy90oz0PR3n6jthq6fYBFBkgJryMCGAD8K/84hYPjxdDVd eC5OS4ntgrw9zIU/KyUjf/hEvim25ix6bKmlU6Vs4wIT7FDi+gXw3KOfsSyRbq4ZQ1NQ r4MKKx2NDCY1RLisaLuW6ktw6gqmVNld+ouus+t82Tn5vzeetEnqqdq4QzAv51NNo/XV uj7nW8LjaGFcV2E4KiAYT3/69xmH6CKyxaFOXg0odAWF2KQwkE7dkM3oS/1Jj0anjwdN X330kN9Ub+L4L0pB+XjJ60K3aqIM0Kb//dynoaFTKi+ZdK+1U+hdjKZUUxjV4BHDl1j/ 84FA== X-Forwarded-Encrypted: i=1; AJvYcCUiICt6jG8xizzLRd3/k8XTsdt1X0xyO0ECXqGejK8mpswzLQ/0DLLRtsV5SXYTpyBxxobSRrXo0mBj9MI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+wYI/hEhFVrQ56j6kDJwDuntm1qdHBqSzhLBAqRl+bnADBcJa T7FNTsb+qWp4rqZ9JSLj9DxNfPmbWaEKAJB2chj+vfwdZLBcEvBKsfQhtjNQJ/uDduxEgLfqm8V 1i0kcrFkQh7Goro9G8HRPFuYOnrdxzw6sLjg4FG9eIOLq5USFRYIrXxxcKyY989hSpu4= X-Gm-Gg: ASbGnctTkKNowI97HW+j4R7Pa15cUttcagFsRrm6mmPBejzag5rh7RQRGqGJHWbv18a 7MNGUh/o2+O2BQaUMwQ2sgMIZrj7VVJscpzo16A16TeZLREqmfc2dURk3JxIFvh9pTvCuRPz3Me zb2E6CsH0HMr3+FGyYUv1giGW1nSwId9a3I0o1pF8wf5BGQ1YAxQk2Ul3TyQkGePLbCoulpSJYJ iRIPJ1lWbN+vkQwTgvoM74z5a3Ra2Odpj5PvralRPh5kPhUuXZz4QqnxGYYqOXuKhHypjlI779w 3HttCIsxvPJOphbeNjtoRv2371siX4lGo/jDlvEcxuqu4G8QDkwkIJhpHg== X-Received: by 2002:a05:6214:c83:b0:6f8:b4aa:2a59 with SMTP id 6a1803df08f44-6fb47758f93mr164247396d6.21.1750142850679; Mon, 16 Jun 2025 23:47:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHHbGqDog8miVnZzjAR3A8q6IF/fQLMGnjyAnp1A2r896ciWBGYbRf0eCtQ5F2t5j3tp+MSYQ== X-Received: by 2002:a05:6214:c83:b0:6f8:b4aa:2a59 with SMTP id 6a1803df08f44-6fb47758f93mr164247136d6.21.1750142850248; Mon, 16 Jun 2025 23:47:30 -0700 (PDT) Received: from trex (132.red-79-144-190.dynamicip.rima-tde.net. [79.144.190.132]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e25302dsm160264035e9.26.2025.06.16.23.47.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 23:47:29 -0700 (PDT) From: Jorge Ramirez X-Google-Original-From: Jorge Ramirez Date: Tue, 17 Jun 2025 08:47:26 +0200 To: Krzysztof Kozlowski Cc: Jorge Ramirez , quic_vgarodia@quicinc.com, quic_dikshita@quicinc.com, bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, stanimir.varbanov@linaro.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] dt-bindings: media: venus: Add qcm2290 dt schema Message-ID: References: <20250613140402.3619465-1-jorge.ramirez@oss.qualcomm.com> <20250613140402.3619465-2-jorge.ramirez@oss.qualcomm.com> <6f4e715f-1c73-450e-b7eb-92781b7fa050@kernel.org> <48e6cc62-ffb0-4ca7-80c8-9e510db505db@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-ORIG-GUID: RXxbhL39BZWADAmZx_I7kDEzaeYSYR2I X-Authority-Analysis: v=2.4 cv=edY9f6EH c=1 sm=1 tr=0 ts=68510f83 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=wjE3nLva0YkvARyJ+Gfmxg==:17 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=ckiIvdw4d6_qyGhr-SIA:9 a=CjuIK1q_8ugA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjE3MDA1NCBTYWx0ZWRfX1wLvj97ZWN12 dic3o9nvHdU3N2F/1P2d9amE+xIiJcyIoSs968Iz7anllPhU+o+yvDkLkZ04lEw8MIHnEQsJ7Gm XhxpI/GUzYkmwM9qL1WC49GzqE4OOA74NrJHqTjSqCSl6DrDtk7FiJtD30JdqA2IDt7hzZcOoAX DjL+gHMbbDNMi18tWD5fv101mcwU0vrXN0CdTnxp1hl/SF5a4Fq+R663tJKRrFEYudJMCWxpghE s/STtmz/go/y2yfhYTPmL6v5Hyit93tsvhatqh2m0zvhPVUqJl4hZLHg52smrbELmjB6D9nG7Zh gFrczIDL/C2Q3WHhON1KgzRZtZKEtaYcfTRgPJssBpAy/G/+SRsWnsYH5OptvLa+BuujzolKIfG AkhBExSoDOrO0dy1iV6zeTiLCA9x02AfKAPa/+qNOfDuBf/q54zhnlkEP6NNWKXZrlbk+nkY X-Proofpoint-GUID: RXxbhL39BZWADAmZx_I7kDEzaeYSYR2I X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-17_02,2025-06-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 spamscore=0 bulkscore=0 impostorscore=0 mlxscore=0 clxscore=1015 mlxlogscore=999 malwarescore=0 phishscore=0 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506170054 On 17/06/25 08:14:23, Krzysztof Kozlowski wrote: > On 16/06/2025 18:59, Jorge Ramirez wrote: > > On 16/06/25 18:23:18, Krzysztof Kozlowski wrote: > >> On 16/06/2025 18:18, Jorge Ramirez wrote: > >>> On 16/06/25 16:41:44, Krzysztof Kozlowski wrote: > >>>> On 16/06/2025 14:52, Jorge Ramirez wrote: > >>>>>> > >>>>>>> + The Venus AR50_LITE IP is a video encode and decode accelerator present > >>>>>>> + on Qualcomm platforms > >>>>>>> + > >>>>>>> +allOf: > >>>>>>> + - $ref: qcom,venus-common.yaml# > >>>>>>> + > >>>>>>> +properties: > >>>>>>> + compatible: > >>>>>>> + const: qcom,qcm2290-venus > >>>>>>> + > >>>>>>> + power-domains: > >>>>>>> + minItems: 2 > >>>>>>> + maxItems: 3 > >>>>>>> + > >>>>>>> + power-domain-names: > >>>>>>> + minItems: 2 > >>>>>> > >>>>>> Why is this flexible? Either you have two or three. Not mixed. > >>>>> > >>>>> please check 5b380f242f360256c96e96adabeb7ce9ec784306 > >>>> > >>>> This does not explain why this is optional HERE. You cannot use for a > >>>> new platform an argument that some existing platform was changed in > >>>> ABI-preserving way. > >>> > >>> thanks for quick the follow up. > >>> > >>> but bear with me please because I dont follow - why can the same logic > >>> be used - it being applicable - and therefore result in a definition > >>> similar to those other platforms? > >> > >> Because this platform either has 2 or 3, not both. Unless that's not > >> true, but then please share some arguments. > > > > as with every other venus schema with more than 1 power domain, the > > argument is the same one that I have shared with you a couple of > > messages back (DVFS). > > > > verbatim: > > Venus needs to vote for the performance state of a power domain (cx) > > to be able to support DVFS. This 'cx' power domain is controlled by > > rpm and is a common power domain (scalable) not specific to > > venus alone. This is optional in the sense that, leaving this power > > domain out does not really impact the functionality but just makes > > the platform a little less power efficient. > > That's not definition of optional. The domain is needed for this device, > the device is one way or another having its rails routed to that domain. > It is not optional. > > > > > Seeing all these venus schemas follow the same pattern, it seems to me > > that this is the correct way of implementing the above. > > No for the reason I mentioned earlier. So just to close this story up, were these two commits wrongly reviewed and signed off then ? Please do notice they were also - just like this one - new additions and not a change in an ABI preserving way as you characterize them. e48b839b6699c2268e545360e06962bb76ff5b8d 8d3a1cb32124eaeb3f2efe4889de214d3b658d8d > > > > > You seem to disagree. please could you explain? > > I already explained. You add new device, so argument to preserve ABI, > which was accepted THAT TIME, is not valid. You do not have ABI. as per the two commits above, this is not an argument to 'presereve' an ABI - this looks to me like an implementation. anyhow, if everyone agrees this is the only way to move this forward will do just fix this to three then. please let me know. > > > Best regards, > Krzysztof