mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	John Ogness <john.ogness@linutronix.de>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Kees Cook <kees@kernel.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	John Ogness <jogness@linutronix.de>,
	David Gow <davidgow@google.com>,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v3] printk: ringbuffer: Add KUnit test
Date: Wed, 18 Jun 2025 17:20:35 +0200	[thread overview]
Message-ID: <aFLZQ4jb928NhBly@pathway.suse.cz> (raw)
In-Reply-To: <aFGDhxefzuWCwOOV@pathway.suse.cz>

On Tue 2025-06-17 17:03:13, Petr Mladek wrote:
> On Thu 2025-06-12 08:29:07, Thomas Weißschuh wrote:
> > The KUnit test validates the correct operation of the ringbuffer.
> > A separate dedicated ringbuffer is used so that the global printk
> > ringbuffer is not touched.
> > 
> > Co-developed-by: John Ogness <john.ogness@linutronix.de>
> > Signed-off-by: John Ogness <john.ogness@linutronix.de>
> > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> 
> Looks good to me:
> 
> Reviewed-by: Petr Mladek <pmladek@suse.com>
> Signed-off-by: Petr Mladek <pmladek@suse.com>

JFYI, the patch has been comitted into printk/linux.git,
branch rework/ringbuffer-kunit-test.

I am going to get it into the mainline in the next merge window
for 6.17.

> PS: I have got an idea to count the number of failed prb_reserve()
>     calls. And it really failed from time to time.
> 
>     I played with it and came up with two more patches. I am going
>     to send them tomorrow. I think that we should solve it separately
>     to avoid too many respins. The current patch is very good as
>     it is now.

I did not have much time to play with it today. I still have to
think about it...

      reply	other threads:[~2025-06-18 15:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12  6:29 Thomas Weißschuh
2025-06-17 15:02 ` Petr Mladek
2025-06-18 15:20   ` Petr Mladek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aFLZQ4jb928NhBly@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=davidgow@google.com \
    --cc=gustavoars@kernel.org \
    --cc=jogness@linutronix.de \
    --cc=john.ogness@linutronix.de \
    --cc=kees@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=thomas.weissschuh@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®