From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fgw21-7.mail.saunalahti.fi (fgw21-7.mail.saunalahti.fi [62.142.5.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AC92146D65 for ; Sat, 21 Jun 2025 19:14:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.142.5.82 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750533298; cv=none; b=JjFbNEpxXUVKLUdGyrDFJDjBu6y1vEntN0zHJiJY38y0GV6sQvVox5GEdrREaISBeUZkSUZfIZW8Kkqh0i8qJVvQk3ntplYFKb5EXXbtChrZxzhfN/RqqUiGZLSek9SzlVBiYYJ3M02qWkOqKSG7s2/eQcHzLx3bhY9ROKC69gs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750533298; c=relaxed/simple; bh=VzszE2v7N/uGW7CYOMd8anuS8+jwt9aMf5ay7XW+9Yk=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MH+yRsXSeBFrCD91NFstvne/Qk5NLoM0Jz/d4tqUEwT/qsM+PDkAO7hW4H5LrqsSo/qDpEEa5ZKDJ/1UQm0rh0tlwU1wvmLv/bNxGhHa/E2Qt+rhTQSKoyEhhESDfB60aFsxtmDEcfDLyHvkxzGwbcqQIGORw87LXQ8EkAFvhvA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=62.142.5.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com Received: from localhost (88-113-26-232.elisa-laajakaista.fi [88.113.26.232]) by fgw21.mail.saunalahti.fi (Halon) with ESMTP id 017ea4bc-4ed4-11f0-9764-005056bdd08f; Sat, 21 Jun 2025 22:14:53 +0300 (EEST) From: Andy Shevchenko Date: Sat, 21 Jun 2025 22:14:51 +0300 To: Anshuman Khandual Cc: Andy Shevchenko , linux-mm@kvack.org, Rasmus Villemoes , Sergey Senozhatsky , Petr Mladek , Steven Rostedt , Jonathan Corbet , Andrew Morton , David Hildenbrand , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [RFC 1/2] lib/vsprintf: Add support for pte_t Message-ID: References: <20250618041235.1716143-1-anshuman.khandual@arm.com> <20250618041235.1716143-2-anshuman.khandual@arm.com> <0d437b3e-37b5-4e98-90bc-afa6c8150e77@arm.com> <92a89dbb-7031-459a-ad5a-69b29b08cfc8@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <92a89dbb-7031-459a-ad5a-69b29b08cfc8@arm.com> Fri, Jun 20, 2025 at 12:23:47PM +0530, Anshuman Khandual kirjoitti: > On 19/06/25 5:30 PM, Andy Shevchenko wrote: > > On Thu, Jun 19, 2025 at 03:05:10PM +0530, Anshuman Khandual wrote: > >> On 18/06/25 11:16 PM, Andy Shevchenko wrote: > >>> On Wed, Jun 18, 2025 at 09:42:34AM +0530, Anshuman Khandual wrote: ... > >>>> + spec.field_width = 10; > >>>> + spec.precision = 8; > >>>> + spec.base = 16; > >>>> + spec.flags = SPECIAL | SMALL | ZEROPAD; > >>> > >>> Do not duplicate code we have already in the file. > >> I am sorry - did not get that. Is the above flag combination some > >> how wrong ? > > > > It's dup. Please, take your time to find the very similar piece of code in one > > of the helper functions we have. > > Are you referring to special_hex_number() ? Bingo! -- With Best Regards, Andy Shevchenko