mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Lechner <dlechner@baylibre.com>
Cc: "Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Mark Brown" <broonie@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH 5/9] iio: adc: ad_sigma_delta: use spi_optimize_message()
Date: Mon, 23 Jun 2025 09:57:45 +0300	[thread overview]
Message-ID: <aFj66Q_TmufwDhyW@smile.fi.intel.com> (raw)
In-Reply-To: <20250620-iio-adc-ad7173-add-spi-offload-support-v1-5-0766f6297430@baylibre.com>

On Fri, Jun 20, 2025 at 05:20:11PM -0500, David Lechner wrote:
> Use spi_optimize_message() to improve the performance of buffered reads.
> 
> By setting up the SPI message and pre-optimizing it in the buffer
> postenable callback, we can reduce overhead during each sample read.
> 
> A rough estimate shows that this reduced the CPU usage of the interrupt
> handler thread from 22% to 16% using an EVAL-AD4112ARDZ board on a
> DE10-Nano (measuring a single channel at the default 6.2 kHz sample
> rate).

...

>  	samples_buf_size += sizeof(int64_t);

Missed conversion in the second patch?

I have done search for these as

	git grep -n 'u?int[0-9][0-9]?_t' -- $FILE(s)


-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2025-06-23  6:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-20 22:20 [PATCH 0/9] iio: adc: ad7173: add SPI offload support David Lechner
2025-06-20 22:20 ` [PATCH 1/9] iio: adc: ad_sigma_delta: sort includes David Lechner
2025-06-22 14:37   ` Jonathan Cameron
2025-06-23  6:50     ` Andy Shevchenko
2025-06-20 22:20 ` [PATCH 2/9] iio: adc: ad_sigma_delta: use u8 instead of uint8_t David Lechner
2025-06-23  6:51   ` Andy Shevchenko
2025-06-23 21:48     ` David Lechner
2025-06-24  7:20       ` Andy Shevchenko
2025-06-20 22:20 ` [PATCH 3/9] iio: adc: ad_sigma_delta: use BITS_TO_BYTES() macro David Lechner
2025-06-22 14:39   ` Jonathan Cameron
2025-06-23  6:54   ` Andy Shevchenko
2025-06-27 23:36     ` David Lechner
2025-06-20 22:20 ` [PATCH 4/9] iio: adc: ad_sigma_delta: refactor setting read address David Lechner
2025-06-20 22:20 ` [PATCH 5/9] iio: adc: ad_sigma_delta: use spi_optimize_message() David Lechner
2025-06-22 14:50   ` Jonathan Cameron
2025-06-23  6:57   ` Andy Shevchenko [this message]
2025-06-20 22:20 ` [PATCH 6/9] dt-bindings: trigger-source: add ADI Util Sigma-Delta SPI David Lechner
2025-06-27 19:59   ` Rob Herring (Arm)
2025-06-20 22:20 ` [PATCH 7/9] spi: offload trigger: add ADI Util Sigma-Delta SPI driver David Lechner
2025-06-20 22:20 ` [PATCH 8/9] iio: adc: ad_sigma_delta: add SPI offload support David Lechner
2025-06-22 15:00   ` Jonathan Cameron
2025-06-22 16:14     ` David Lechner
2025-06-23 10:21   ` kernel test robot
2025-06-23 13:55   ` kernel test robot
2025-06-20 22:20 ` [PATCH 9/9] iio: adc: ad7173: " David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aFj66Q_TmufwDhyW@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®