From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Will McVicker <willmcvicker@google.com>
Cc: "Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Rob Herring" <robh@kernel.org>,
"Saravana Kannan" <saravanak@google.com>,
"Donghoon Yu" <hoony.yu@samsung.com>,
"Hosung Kim" <hosung0.kim@samsung.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "John Stultz" <jstultz@google.com>,
"Youngmin Nam" <youngmin.nam@samsung.com>,
"Peter Griffin" <peter.griffin@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 4/6] clocksource/drivers/exynos_mct: Fix uninitialized irq name warning
Date: Tue, 24 Jun 2025 15:22:12 +0200 [thread overview]
Message-ID: <aFqmhDQnlUHh4vLY@mai.linaro.org> (raw)
In-Reply-To: <20250618210851.661527-5-willmcvicker@google.com>
On Wed, Jun 18, 2025 at 02:08:41PM -0700, Will McVicker wrote:
> The Exynos MCT driver doesn't set the clocksource name until the CPU
> hotplug state is setup which happens after the IRQs are requested. This
> results in an empty IRQ name which leads to the below warning at
> proc_create() time. When this happens, the userdata partition fails to
> mount and the device gets stuck in an endless loop printing the error:
>
> root '/dev/disk/by-partlabel/userdata' doesn't exist or does not contain a /dev.
>
> To fix this, we just need to initialize the name before requesting the
> IRQs.
>
> Warning from Pixel 6 kernel log:
>
> [ T430] name len 0
> [ T430] WARNING: CPU: 6 PID: 430 at fs/proc/generic.c:407 __proc_create+0x258/0x2b4
> [ T430] Modules linked in: dwc3_exynos(E+)
> [ T430] ufs_exynos(E+) phy_exynos_ufs(E)
> [ T430] phy_exynos5_usbdrd(E) exynos_usi(E+) exynos_mct(E+) s3c2410_wdt(E)
> [ T430] arm_dsu_pmu(E) simplefb(E)
> [ T430] CPU: 6 UID: 0 PID: 430 Comm: (udev-worker) Tainted:
> ... 6.14.0-next-20250331-4k-00008-g59adf909e40e #1 ...
> [ T430] Tainted: [W]=WARN, [E]=UNSIGNED_MODULE
> [ T430] Hardware name: Raven (DT)
> [...]
> [ T430] Call trace:
> [ T430] __proc_create+0x258/0x2b4 (P)
> [ T430] proc_mkdir+0x40/0xa0
> [ T430] register_handler_proc+0x118/0x140
> [ T430] __setup_irq+0x460/0x6d0
> [ T430] request_threaded_irq+0xcc/0x1b0
> [ T430] mct_init_dt+0x244/0x604 [exynos_mct ...]
> [ T430] mct_init_spi+0x18/0x34 [exynos_mct ...]
> [ T430] exynos4_mct_probe+0x30/0x4c [exynos_mct ...]
> [ T430] platform_probe+0x6c/0xe4
> [ T430] really_probe+0xf4/0x38c
> [...]
> [ T430] driver_register+0x6c/0x140
> [ T430] __platform_driver_register+0x28/0x38
> [ T430] exynos4_mct_driver_init+0x24/0xfe8 [exynos_mct ...]
> [ T430] do_one_initcall+0x84/0x3c0
> [ T430] do_init_module+0x58/0x208
> [ T430] load_module+0x1de0/0x2500
> [ T430] init_module_from_file+0x8c/0xdc
>
> Reviewed-by: Peter Griffin <peter.griffin@linaro.org>
> Reviewed-by: Youngmin Nam <youngmin.nam@samsung.com>
> Tested-by: Youngmin Nam <youngmin.nam@samsung.com>
> Signed-off-by: Will McVicker <willmcvicker@google.com>
> ---
> drivers/clocksource/exynos_mct.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
> index a5ef7d64b1c2..62febeb4e1de 100644
> --- a/drivers/clocksource/exynos_mct.c
> +++ b/drivers/clocksource/exynos_mct.c
> @@ -465,8 +465,6 @@ static int exynos4_mct_starting_cpu(unsigned int cpu)
> per_cpu_ptr(&percpu_mct_tick, cpu);
> struct clock_event_device *evt = &mevt->evt;
>
> - snprintf(mevt->name, sizeof(mevt->name), "mct_tick%d", cpu);
> -
> evt->name = mevt->name;
> evt->cpumask = cpumask_of(cpu);
> evt->set_next_event = exynos4_tick_set_next_event;
> @@ -567,6 +565,14 @@ static int __init exynos4_timer_interrupts(struct device_node *np,
> for (i = MCT_L0_IRQ; i < nr_irqs; i++)
> mct_irqs[i] = irq_of_parse_and_map(np, i);
>
> + for_each_possible_cpu(cpu) {
> + struct mct_clock_event_device *mevt =
> + per_cpu_ptr(&percpu_mct_tick, cpu);
> +
> + snprintf(mevt->name, sizeof(mevt->name), "mct_tick%d",
> + cpu);
> + }
> +
> if (mct_int_type == MCT_INT_PPI) {
>
> err = request_percpu_irq(mct_irqs[MCT_L0_IRQ],
> --
> 2.50.0.rc2.761.g2dc52ea45b-goog
>
There are too many for_each_possible_cpu() loops in this function.
Why not move the per cpu relevant code in the hotplug callbacks ?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2025-06-24 13:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 21:08 [PATCH v3 0/6] Add module support for Arm64 Exynos MCT driver Will McVicker
2025-06-18 21:08 ` [PATCH 1/6] of/irq: Export of_irq_count for modules Will McVicker
2025-06-18 21:08 ` [PATCH 2/6] clocksource/drivers/exynos_mct: Don't register as a sched_clock on arm64 Will McVicker
2025-06-18 21:08 ` [PATCH 3/6] clocksource/drivers/exynos_mct: Set local timer interrupts as percpu Will McVicker
2025-06-18 21:08 ` [PATCH 4/6] clocksource/drivers/exynos_mct: Fix uninitialized irq name warning Will McVicker
2025-06-24 13:22 ` Daniel Lezcano [this message]
2025-06-18 21:08 ` [PATCH 5/6] clocksource/drivers/exynos_mct: Add module support Will McVicker
2025-06-19 20:22 ` kernel test robot
2025-06-18 21:08 ` [PATCH 6/6] arm64: exynos: Drop select CLKSRC_EXYNOS_MCT Will McVicker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFqmhDQnlUHh4vLY@mai.linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hoony.yu@samsung.com \
--cc=hosung0.kim@samsung.com \
--cc=jstultz@google.com \
--cc=kernel-team@android.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=tglx@linutronix.de \
--cc=tudor.ambarus@linaro.org \
--cc=will@kernel.org \
--cc=willmcvicker@google.com \
--cc=youngmin.nam@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®