mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Jorge Marques <jorge.marques@analog.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i3c: master: Initialize ret in i3c_i2c_notifier_call()
Date: Tue, 24 Jun 2025 15:04:53 -0400	[thread overview]
Message-ID: <aFr21Yj5AgKSadxg@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20250622-i3c-master-ret-uninitialized-v1-1-aabb5625c932@analog.com>

On Sun, Jun 22, 2025 at 12:11:07PM +0200, Jorge Marques wrote:
> Set ret to -EINVAL if i3c_i2c_notifier_call() receives an invalid
> action, resolving uninitialized warning.
>
> Signed-off-by: Jorge Marques <jorge.marques@analog.com>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
> If a invalid action was passed to i3c_i2c_notifier_call(), uninitialized
> would be returned. Add a default option in the switch case to set it as
> -EINVAL; I didn't set at the variable definition for readability
> purpose. The warning was caught by smatch.
> ---
>  drivers/i3c/master.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index fd81871609d95bc082bd401681e7e132ea74f8a7..68b8ea9174b984a6c89b389c4b3a9669239def70 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -2467,6 +2467,8 @@ static int i3c_i2c_notifier_call(struct notifier_block *nb, unsigned long action
>  	case BUS_NOTIFY_DEL_DEVICE:
>  		ret = i3c_master_i2c_detach(adap, client);
>  		break;
> +	default:
> +		ret = -EINVAL;
>  	}
>  	i3c_bus_maintenance_unlock(&master->bus);
>
>
> ---
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> change-id: 20250622-i3c-master-ret-uninitialized-16265d8a8719
>
> Best regards,
> --
> Jorge Marques <jorge.marques@analog.com>
>
>
>
> --
> linux-i3c mailing list
> linux-i3c@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-i3c

  reply	other threads:[~2025-06-24 19:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-22 10:11 Jorge Marques
2025-06-24 19:04 ` Frank Li [this message]
2025-07-03 23:24 ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aFr21Yj5AgKSadxg@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=jorge.marques@analog.com \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®