Re: [PATCH v5] NDI FTDI USB driver support

[Johan Hovold <johan@kernel.org>]

On Wed, Jul 09, 2025 at 01:50:15PM +0000, Ryan Mann wrote:
> From: Ryan Mann (NDI) <rmann@ndigital.com>
> 
> NDI (Northern Digital Inc.) is introducing a new product called the 
> EMGUIDE GEMINI that will use an FTDI chip for USB serial communications.
> Add the NDI EMGUIDE GEMINI product ID that uses the NDI Vendor ID
> rather than the FTDI Vendor ID, unlike older products.
> 
> Signed-off-by: Ryan Mann <rmann@ndigital.com>
> ---
> V1 -> V2: Email-to issues fixed
> V2 -> V3: Email formatting issues fixed, removed future devices
> V3 -> V4: Email formatting issues fixed, removed extra comments
> V4 -> V5:	Diff whitespace issues fixed,
> 			Restored the Aurora SCU device mapping that was removed

> +	{ USB_DEVICE(NDI_VID, FTDI_NDI_EMGUIDE_GEMINI_PID),
> +		.driver_info = (kernel_ulong_t)&ftdi_NDI_device_quirk },

I was going to apply this, but turns out it does not even compile.

Sending completely untested patches like this is really not acceptable.

> +#define FTDI_NDI_VID			0x23F2

Also change your Subject to use the common prefix ("USB: serial:
ftdi_sio: ..." when respinning.

Johan