Re: [PATCH 2/2] media: i2c: add ov2735 image sensor driver

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Tue, Jul 08, 2025 at 07:04:48AM +0000, Hardevsinh Palaniya wrote:
> > On Mon, Jul 07, 2025 at 08:31:06PM +0530, Hardevsinh Palaniya wrote:

...

> > > +static int ov2735_disable_streams(struct v4l2_subdev *sd,
> > > +                               struct v4l2_subdev_state *state, u32 pad,
> > > +                               u64 streams_mask)
> > > +{
> > > +     struct ov2735 *ov2735 = to_ov2735(sd);
> > > +     int ret = 0;
> > > +
> > > +     /* set stream off register */
> > > +     ret = cci_write(ov2735->cci, OV2735_REG_PAGE_SELECT, 0x01, NULL);
> > > +     ret |= cci_write(ov2735->cci, OV2735_REG_STREAM_CTRL, OV2735_STREAM_OFF, NULL);
> > 
> > Why not using the ret parameter? Same for other similar cases above and beyond.
> 
> I am not sure what you want to suggest here.
> 
> Do I need to check ret like this?
> 
> ret = cci_write(ov2735->cci, OV2735_REG_PAGE_SELECT, 0x01, NULL);
> if (ret) {
>     // error message
> }
> 
> ret = cci_write(ov2735->cci, OV2735_REG_STREAM_CTRL, OV2735_STREAM_OFF, NULL);
> if (ret) {
>     // error message
> }

No, this is the idea behind it, you check only when you need it.

-- 
With Best Regards,
Andy Shevchenko