From: Frank Li <Frank.li@nxp.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: "Jon Mason" <jdmason@kudzu.us>,
"Dave Jiang" <dave.jiang@intel.com>,
"Allen Hubbe" <allenbh@gmail.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
ntb@lists.linux.dev, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: endpoint: pci-epf-vntb: fix MW2 configfs id
Date: Tue, 8 Jul 2025 13:52:26 -0400 [thread overview]
Message-ID: <aG1a2iy1/2RWd2FX@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20250708-vntb-mw-fixup-v1-1-22da511247ed@baylibre.com>
On Tue, Jul 08, 2025 at 04:49:57PM +0200, Jerome Brunet wrote:
> The id associated with MW2 configfs entry is wrong.
> Trying to use MW2 will overwrite the existing BAR setup associated with
> MW1.
:%s/id/ID
need new line between two paragraph.
Frank
>
> Just put the correct id for MW2 to fix the situation
>
> Fixes: 4eacb24f6fa3 ("PCI: endpoint: pci-epf-vntb: Allow BAR assignment via configfs")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> drivers/pci/endpoint/functions/pci-epf-vntb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> index 41b297b16574558e7ab99fb047204ac29f6f3391..ac83a6dc6116be190f955adc46a30d065d3724fd 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> @@ -993,8 +993,8 @@ EPF_NTB_BAR_R(db_bar, BAR_DB)
> EPF_NTB_BAR_W(db_bar, BAR_DB)
> EPF_NTB_BAR_R(mw1_bar, BAR_MW1)
> EPF_NTB_BAR_W(mw1_bar, BAR_MW1)
> -EPF_NTB_BAR_R(mw2_bar, BAR_MW1)
> -EPF_NTB_BAR_W(mw2_bar, BAR_MW1)
> +EPF_NTB_BAR_R(mw2_bar, BAR_MW2)
> +EPF_NTB_BAR_W(mw2_bar, BAR_MW2)
> EPF_NTB_BAR_R(mw3_bar, BAR_MW3)
> EPF_NTB_BAR_W(mw3_bar, BAR_MW3)
> EPF_NTB_BAR_R(mw4_bar, BAR_MW4)
>
> ---
> base-commit: 38be2ac97d2df0c248b57e19b9a35b30d1388852
> change-id: 20250708-vntb-mw-fixup-bc30a3e29061
>
> Best regards,
> --
> Jerome
>
next prev parent reply other threads:[~2025-07-08 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 14:49 Jerome Brunet
2025-07-08 17:52 ` Frank Li [this message]
2025-07-09 8:16 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aG1a2iy1/2RWd2FX@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=allenbh@gmail.com \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=jbrunet@baylibre.com \
--cc=jdmason@kudzu.us \
--cc=kishon@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
--cc=ntb@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®