Re: [PATCH v2 01/12] iio: accel: Remove redundant pm_runtime_mark_last_busy() calls

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Wed, Jul 09, 2025 at 02:11:51AM +0300, Sakari Ailus wrote:
> pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
> pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
> to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
> pm_runtime_mark_last_busy().

...

> -	if (on) {
> +	if (on)
>  		ret = pm_runtime_resume_and_get(dev);
> -	} else {
> -		pm_runtime_mark_last_busy(dev);
> +	else
>  		ret = pm_runtime_put_autosuspend(dev);
> -	}

The following blank line can be removed as it's done in the other file.

...

Side note: Looking at this, perhaps we can also have a helper to toggle state?

...

>  	if (on)
>  		ret = pm_runtime_resume_and_get(&data->client->dev);
> -	else {
> -		pm_runtime_mark_last_busy(&data->client->dev);
> +	else
>  		ret = pm_runtime_put_autosuspend(&data->client->dev);
> -	}

So, already two users of the potential new helper :-)

...

> -	if (on) {
> +	if (on)
>  		ret = pm_runtime_resume_and_get(&client->dev);
> -	} else {
> -		pm_runtime_mark_last_busy(&client->dev);
> +	else
>  		ret = pm_runtime_put_autosuspend(&client->dev);
> -	}
>  

No blank line?

Three!

>  	if (ret < 0) {

...

>  	if (on)
>  		ret = pm_runtime_resume_and_get(&client->dev);
> -	else {
> -		pm_runtime_mark_last_busy(&client->dev);
> +	else
>  		ret = pm_runtime_put_autosuspend(&client->dev);
> -	}
>  
>  	if (ret < 0) {

As per above and counting...

-- 
With Best Regards,
Andy Shevchenko