mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>,
	"open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"moderated list:ARM/LPC32XX SOC SUPPORT"
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>,
	imx@lists.linux.dev
Subject: Re: [PATCH v2 1/1] dt-bindings: usb: convert lpc32xx-udc.txt to yaml format
Date: Sun, 29 Jun 2025 11:55:54 -0400	[thread overview]
Message-ID: <aGFiCsXWaubBBk7I@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <a15cbc55-f0ba-4c15-af27-44b05285bc16@mleia.com>

On Sat, Jun 28, 2025 at 03:57:44AM +0300, Vladimir Zapolskiy wrote:
> Hi Frank.
>
> On 6/26/25 00:43, Frank Li wrote:
> > Convert lpc32xx-udc.txt to yaml format.
> >
> > Additional changes:
> > - add clocks and put it into required list to match existed lp32xx.dtsi.
> > - remove usb-transceiver@2c at examples.
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
>
> Thank you a lot for doing this massive conversion work of NXP LPC
> device tree bindings, I would appreciate, if you put me to CC for
> all such changes.
>
> While you do one-to-one conversion, you do bring a lot of errors,
> because the .txt descriptions are broken.
>
> Please always reference to arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> and arch/arm/boot/dts/nxp/lpc/lpc18xx.dtsi, that's the correct
> version of NXP LPC DT bindings, otherwise something important
> can be missed by occasion.

Okay, I dependent on CHECK_DTBS but omit the factor the node with status
="disabled" will skip check.

Frank

>
> <snip>
>
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/lpc32xx-clock.h>
> > +
> > +    usbd@31020000 {
> > +        compatible = "nxp,lpc3220-udc";
> > +        reg = <0x31020000 0x300>;
> > +        interrupt-parent = <&mic>;
>
> interrupt-parent = <sic1>;
>
> > +        interrupts = <0x3d 0>, <0x3e 0>, <0x3c 0>, <0x3a 0>;
>
> Should subscribe 32 and correct the type:
>
> interrupts = <29 4>, <30 4>, <28 4>, <26 8>;
>
> > +        clocks = <&usbclk LPC32XX_USB_CLK_DEVICE>;
> > +        transceiver = <&isp1301>;
> > +    };
>
> --
> Best wishes,
> Vladimir

      reply	other threads:[~2025-06-29 15:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-25 21:43 Frank Li
2025-06-27 21:19 ` Rob Herring (Arm)
2025-06-28  0:57 ` Vladimir Zapolskiy
2025-06-29 15:55   ` Frank Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aGFiCsXWaubBBk7I@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=piotr.wojtaszczyk@timesys.com \
    --cc=robh@kernel.org \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®