mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yury Norov <yury.norov@gmail.com>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
	Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uapi: bitops: use UAPI-safe variant of BITS_PER_LONG again (2)
Date: Tue, 1 Jul 2025 17:37:40 -0400	[thread overview]
Message-ID: <aGRVJHZF36KGVs4c@yury> (raw)
In-Reply-To: <aGKkw6b1QPTf9yii@yury>

On Mon, Jun 30, 2025 at 10:52:54AM -0400, Yury Norov wrote:
> On Mon, Jun 30, 2025 at 03:02:18PM +0200, Thomas Weißschuh wrote:
> > BITS_PER_LONG does not exist in UAPI headers, so can't be used by the UAPI
> > __GENMASK(). Instead __BITS_PER_LONG needs to be used.
> > 
> > When __GENMASK() was introduced in commit 3c7a8e190bc5 ("uapi: introduce uapi-friendly macros for GENMASK"),
> > the code was fine. A broken revert in 1e7933a575ed ("uapi: Revert "bitops: avoid integer overflow in GENMASK(_ULL)"")
> > introduced the incorrect usage of BITS_PER_LONG.
> > That was fixed in commit 11fcf368506d ("uapi: bitops: use UAPI-safe variant of BITS_PER_LONG again").
> > But a broken sync of the kernel headers with the tools/ headers in
> > commit fc92099902fb ("tools headers: Synchronize linux/bits.h with the kernel sources")
> > undid the fix.
> > 
> > Reapply the fix and while at it also fix the tools header.
> > 
> > Fixes: fc92099902fb ("tools headers: Synchronize linux/bits.h with the kernel sources")
> > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> 
> Acked-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
> 
> Arnaldo, do you want to move it yourself or with my branch?

OK, added this in bitmap-for-next together with the MAINTAINERS patch.

Thanks Tomas for looking after that!

Thanks,
Yury

  reply	other threads:[~2025-07-01 21:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-30 13:02 Thomas Weißschuh
2025-06-30 14:52 ` Yury Norov
2025-07-01 21:37   ` Yury Norov [this message]
2025-07-08  6:26     ` Thomas Weißschuh
2025-07-08 14:47       ` Yury Norov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aGRVJHZF36KGVs4c@yury \
    --to=yury.norov@gmail.com \
    --cc=acme@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=thomas.weissschuh@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®