From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips: boot: use 'targets' instead of extra-y in Makefile
Date: Wed, 2 Jul 2025 14:14:47 +0200 [thread overview]
Message-ID: <aGUit7vdpeC1jVm8@alpha.franken.de> (raw)
In-Reply-To: <20250608015136.2960777-1-masahiroy@kernel.org>
On Sun, Jun 08, 2025 at 10:51:34AM +0900, Masahiro Yamada wrote:
> vmlinux.bin.* files are built as prerequisites of other objects.
> There is no need to use extra-y, which is planned for deprecation.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> arch/mips/boot/Makefile | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/mips/boot/Makefile b/arch/mips/boot/Makefile
> index 196c44fa72d9..8473c4671702 100644
> --- a/arch/mips/boot/Makefile
> +++ b/arch/mips/boot/Makefile
> @@ -54,10 +54,10 @@ UIMAGE_ENTRYADDR = $(VMLINUX_ENTRY_ADDRESS)
> # Compressed vmlinux images
> #
>
> -extra-y += vmlinux.bin.bz2
> -extra-y += vmlinux.bin.gz
> -extra-y += vmlinux.bin.lzma
> -extra-y += vmlinux.bin.lzo
> +targets += vmlinux.bin.bz2
> +targets += vmlinux.bin.gz
> +targets += vmlinux.bin.lzma
> +targets += vmlinux.bin.lzo
>
> $(obj)/vmlinux.bin.bz2: $(obj)/vmlinux.bin FORCE
> $(call if_changed,bzip2)
> --
> 2.43.0
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2025-07-02 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-08 1:51 Masahiro Yamada
2025-07-02 12:14 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGUit7vdpeC1jVm8@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®