From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5B63629E11B for ; Mon, 21 Jul 2025 14:42:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753108944; cv=none; b=F2bQ46eu7R8cGmz0j+UmqHOdj12CkVhEh7Qh11o7P2gLmDz97u98UlRJfD7EN3DEG9bssYH1hhBdzRUkb2u+6Xrau1XirKSKMZp4hKBihKK0dx2jO+TOFiECTjh2aJ/8WACaiINeEdMIYSJc8oLPM3eYpv/cHXL6Es+ISBFyNDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753108944; c=relaxed/simple; bh=vRI13+t3W6H9dwChMtH3yD9kkUrqad2cx8GfagUxlUE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Xi4XY2ryN7qWnrjJ45v20deFwpsGDT1+rygSD6Ke7H2vsvkVBv1G8A9UyObnwKpeoBuvYdIcv0tzI7KkUNsrUopPPwQpjF7E8b0/BgN8efAY6k3TsgnpponGkn3uyPUgpouR8krSHHv/JwZZVXqWZrhNYRjUZiIv2R4iRMMDaao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EC006153B for ; Mon, 21 Jul 2025 07:42:16 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 838153F66E for ; Mon, 21 Jul 2025 07:42:22 -0700 (PDT) Date: Mon, 21 Jul 2025 15:42:12 +0100 From: Liviu Dudau To: Karunika Choo Cc: dri-devel@lists.freedesktop.org, nd@arm.com, Boris Brezillon , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/6] drm/panthor: Add support for Mali-G710, Mali-G510 and Mali-G310 Message-ID: References: <20250721111344.1610250-1-karunika.choo@arm.com> <20250721111344.1610250-4-karunika.choo@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250721111344.1610250-4-karunika.choo@arm.com> On Mon, Jul 21, 2025 at 12:13:41PM +0100, Karunika Choo wrote: > This patch adds GPU model name and FW binary support for Mali-G710, > Mali-G510, and Mali-G310. > > Signed-off-by: Karunika Choo Reviewed-by: Liviu Dudau Best regards, Liviu > --- > drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ > drivers/gpu/drm/panthor/panthor_hw.c | 6 ++++++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c > index 36f1034839c2..b7b454d16f12 100644 > --- a/drivers/gpu/drm/panthor/panthor_fw.c > +++ b/drivers/gpu/drm/panthor/panthor_fw.c > @@ -1402,3 +1402,5 @@ int panthor_fw_init(struct panthor_device *ptdev) > } > > MODULE_FIRMWARE("arm/mali/arch10.8/mali_csffw.bin"); > +MODULE_FIRMWARE("arm/mali/arch10.10/mali_csffw.bin"); > +MODULE_FIRMWARE("arm/mali/arch10.12/mali_csffw.bin"); > diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/gpu/drm/panthor/panthor_hw.c > index f39010c0ca86..7f138974d43b 100644 > --- a/drivers/gpu/drm/panthor/panthor_hw.c > +++ b/drivers/gpu/drm/panthor/panthor_hw.c > @@ -15,8 +15,14 @@ static char *get_gpu_model_name(struct panthor_device *ptdev) > GPU_PROD_MAJOR(gpu_id)); > > switch (product_id) { > + case GPU_PROD_ID_MAKE(10, 2): > + return "Mali-G710"; > case GPU_PROD_ID_MAKE(10, 7): > return "Mali-G610"; > + case GPU_PROD_ID_MAKE(10, 3): > + return "Mali-G510"; > + case GPU_PROD_ID_MAKE(10, 4): > + return "Mali-G310"; > } > > return "(Unknown Mali GPU)"; > -- > 2.49.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯