mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yeoreum Yun <yeoreum.yun@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: catalin.marinas@arm.com, will@kernel.org, broonie@kernel.org,
	oliver.upton@linux.dev, ardb@kernel.org, frederic@kernel.org,
	james.morse@arm.com, joey.gouly@arm.com,
	scott@os.amperecomputing.com, maz@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/7] arm64/futex: move futex atomic logic with clearing PAN bit
Date: Tue, 22 Jul 2025 09:21:19 +0100	[thread overview]
Message-ID: <aH9J/9hZympA5ZoG@e129823.arm.com> (raw)
In-Reply-To: <aH4c8J3-qp9guE__@J2N7QTR9R3>

Hi Mark,

> > Move current futex atomic logics which uses ll/sc method with cleraing
> > PSTATE.PAN to separate file (futex_ll_sc_u.h) so that
> > former method will be used only when FEAT_LSUI isn't supported.
>
> This isn't moving logic, this is *duplicating* the existing logic. As of
> this patch, this logic in the <asm/futex_ll_sc_u.h> header is unused,
> and the existing logic in <asm/futex.h> is still used as-is.
>
> Please refactor the existing logic first. The deletion of the existing
> code should happen at the same time as this addition. That way it's
> possible to see that the deleted logic corresponds to what is being
> added in the header, and it's generally nicer for bisection.
>
> Mark.

Thanks for this :)
As you suggest in other comments, I'll respin in <asm/futex.h> only.

[...]

--
Sincerely,
Yeoreum Yun

  reply	other threads:[~2025-07-22  8:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-21  8:36 [PATCH v4 0/7] support FEAT_LSUI and apply it on futex atomic ops Yeoreum Yun
2025-07-21  8:36 ` [PATCH v4 1/7] arm64: cpufeature: add FEAT_LSUI Yeoreum Yun
2025-07-21  8:36 ` [PATCH v4 2/7] KVM/arm64: expose FEAT_LSUI to guest Yeoreum Yun
2025-07-21  8:36 ` [PATCH v4 3/7] arm64/Kconfig: add LSUI Kconfig Yeoreum Yun
2025-07-21 10:52   ` Mark Rutland
2025-07-22  8:17     ` Yeoreum Yun
2025-07-21  8:36 ` [PATCH v4 4/7] arm64/futex: move futex atomic logic with clearing PAN bit Yeoreum Yun
2025-07-21 10:56   ` Mark Rutland
2025-07-22  8:21     ` Yeoreum Yun [this message]
2025-07-21  8:36 ` [PATCH v4 5/7] arm64/futex: add futex atomic operation with FEAT_LSUI Yeoreum Yun
2025-07-21 11:03   ` Mark Rutland
2025-07-22  8:34     ` Yeoreum Yun
2025-07-21  8:36 ` [PATCH v4 6/7] arm64/asm: introduce lsui.h Yeoreum Yun
2025-07-21  8:36 ` [PATCH v4 7/7] arm64/futex: support futex with FEAT_LSUI Yeoreum Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aH9J/9hZympA5ZoG@e129823.arm.com \
    --to=yeoreum.yun@arm.com \
    --cc=ardb@kernel.org \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=frederic@kernel.org \
    --cc=james.morse@arm.com \
    --cc=joey.gouly@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=scott@os.amperecomputing.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®